Issue 256020: Make scons 'loadable_module' output consistent with make output location...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 256020: Make scons 'loadable_module' output consistent with make output location... (Closed)

Created:
11 years, 2 months ago by Michael Moss

Modified:
9 years, 7 months ago

Reviewers:
sgk

CC:
gyp-developer_googlegroups.com

Base URL:
http://gyp.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Make 'loadable_module' output consistent between make and scons generators. Committed: http://code.google.com/p/gyp/source/detail?r=676

Patch Set 2 : '' #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+205 lines, -3 lines)			Patch
M	pylib/gyp/generator/make.py	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	pylib/gyp/generator/scons.py	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
A	test/module/gyptest-default.py	View		1 chunk	+24 lines, -0 lines	0 comments	Download
A	test/module/src/lib1.c	View		1 chunk	+10 lines, -0 lines	0 comments	Download
A	test/module/src/lib2.c	View		1 chunk	+10 lines, -0 lines	0 comments	Download
A	test/module/src/module.gyp	View		1 chunk	+46 lines, -0 lines	0 comments	Download
A	test/module/src/program.c	View	1	1 chunk	+111 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sgk

lgtm, one nit. excellent test case, thanks http://codereview.chromium.org/256020/diff/4004/3021 File pylib/gyp/generator/scons.py (right): http://codereview.chromium.org/256020/diff/4004/3021#newcode714 Line 714: result ...

11 years, 2 months ago (2009-10-01 23:46:30 UTC) #2

Added the fix for make's "liblib" naming.

Expand Messages | Collapse Messages

Issue 256020: Make scons 'loadable_module' output consistent with make output location... (Closed)

Description

Patch Set 1 : '' #

Patch Set 2 : '' #

Messages