Timeline: fix screenshots for headless shell

Timeline: fix screenshots for headless shell

Timeline relied on hard-coded name of the browser process to locate
the browser main thread. This introduces a more defensive way of
finding the browser in the trace.

BUG=627547
Committed: https://crrev.com/73365a379eb84bf5b54c85afe9565fc109e92809
Cr-Commit-Position: refs/heads/master@{#421708}

[caseq, 2016-09-28 23:51:08]

Patchset #1 (id:1) has been deleted

[caseq, 2016-09-28 23:54:55]

Patchset #1 (id:20001) has been deleted

[caseq, 2016-09-28 23:55:36]

caseq@chromium.org changed reviewers:
+ alph@chromium.org, paulirish@chromium.org

[alph, 2016-09-29 00:12:54]

https://codereview.chromium.org/2378843003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/TracingModel.js (right):

https://codereview.chromium.org/2378843003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/TracingModel.js:123: * FIXME:
this is here just for convenience of re-use between modules.
TODO

https://codereview.chromium.org/2378843003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/TracingModel.js:130: var
browserProcess = [];
nit: browserProcesses

https://codereview.chromium.org/2378843003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/TracingModel.js:133: if
(process.name().toLowerCase().endsWith("Browser"))
browser

[alph, 2016-09-29 00:13:00]

lgtm

[caseq, 2016-09-29 00:24:12]

On 2016/09/29 00:12:54, alph wrote:
>
https://codereview.chromium.org/2378843003/diff/40001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/devtools/front_end/sdk/TracingModel.js (right):
> 
>
https://codereview.chromium.org/2378843003/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/devtools/front_end/sdk/TracingModel.js:123: * FIXME:
> this is here just for convenience of re-use between modules.
> TODO

Fixed.

> 
>
https://codereview.chromium.org/2378843003/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/devtools/front_end/sdk/TracingModel.js:130: var
> browserProcess = [];
> nit: browserProcesses

Done.

>
https://codereview.chromium.org/2378843003/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/devtools/front_end/sdk/TracingModel.js:133: if
> (process.name().toLowerCase().endsWith("Browser"))
> browser

Ouch! Thanks for catching!

[caseq, 2016-09-29 00:24:48]

The CQ bit was checked by caseq@chromium.org

[caseq, 2016-09-29 00:24:49]

The patchset sent to the CQ was uploaded after l-g-t-m from alph@chromium.org
Link to the patchset: https://codereview.chromium.org/2378843003/#ps60001
(title: "review comments addressed")

[commit-bot: I haz the power, 2016-09-29 00:25:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 01:46:12]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-09-29 01:49:21]

Description was changed from

==========
Timeline: fix screenshots for headless shell

Timeline relied on hard-coded name of the browser process to locate
the browser main thread. This introduces a more defensive way of
finding the browser in the trace.

BUG=627547
==========

to

==========
Timeline: fix screenshots for headless shell

Timeline relied on hard-coded name of the browser process to locate
the browser main thread. This introduces a more defensive way of
finding the browser in the trace.

BUG=627547

Committed: https://crrev.com/73365a379eb84bf5b54c85afe9565fc109e92809
Cr-Commit-Position: refs/heads/master@{#421708}
==========

[commit-bot: I haz the power, 2016-09-29 01:49:22]

Patchset 2 (id:??) landed as
https://crrev.com/73365a379eb84bf5b54c85afe9565fc109e92809
Cr-Commit-Position: refs/heads/master@{#421708}