third_party/WebKit/Source/devtools/front_end/components_lazy/FilmStripModel.js - Issue 2378843003: Timeline: fix screenshots for headless shell

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/components_lazy/FilmStripModel.js

Issue 2378843003: Timeline: fix screenshots for headless shell (Closed)

Patch Set: review comments addressed Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/tracing-browser-thread-expected.txt ('k') | third_party/WebKit/Source/devtools/front_end/sdk/TracingModel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/components_lazy/FilmStripModel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/components_lazy/FilmStripModel.js b/third_party/WebKit/Source/devtools/front_end/components_lazy/FilmStripModel.js

index 7b416245b39978c913ccf00bf1592f9e50be192f..f9533734b8d6ec691d2747552bdf7197780329c8 100644

--- a/third_party/WebKit/Source/devtools/front_end/components_lazy/FilmStripModel.js

+++ b/third_party/WebKit/Source/devtools/front_end/components_lazy/FilmStripModel.js

@@ -33,15 +33,11 @@ WebInspector.FilmStripModel.prototype = {

/** @type {!Array<!WebInspector.FilmStripModel.Frame>} */

this._frames = [];

- var browserProcess = tracingModel.processByName("Browser");

- if (!browserProcess)

- return;

- var mainThread = browserProcess.threadByName("CrBrowserMain");

- if (!mainThread)

+ var browserMain = WebInspector.TracingModel.browserMainThread(tracingModel);

+ if (!browserMain)

return;

- var events = mainThread.events();

+ var events = browserMain.events();

for (var i = 0; i < events.length; ++i) {

var event = events[i];

if (event.startTime < this._zeroTime)