Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 23788010: Revert 221966 "Revert 221944 "Add UMA to report Preferences File..." (Closed)

Created:
7 years, 3 months ago by Vitaly Buka (NO REVIEWS)
Modified:
7 years, 3 months ago
Reviewers:
bbudge
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 221966 "Revert 221944 "Add UMA to report Preferences File..." Re-apply and disable for Chrome Frame. > Revert 221944 "Add UMA to report Preferences File Corruption" > > Breaks chrome_frame_tests on Win Aura. > http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Chromium&testType=chrome_frame_tests&builder=Win%20Aura%20Tests%20(1) > > > Add UMA to report Preferences File Corruption > > Adds PrefMetricsService methods to track changes to user preferences > > that happen outside of Chrome and report discrepancies via UMA. > > > > BUG=266569 > > > > Review URL: https://chromiumcodereview.appspot.com/22676002 > > TBR=bbudge@chromium.org > > Review URL: https://codereview.chromium.org/23597020 TBR=bbudge@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221972

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+337 lines, -17 lines) Patch
M trunk/src/chrome/browser/browser_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/prefs/browser_prefs.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/prefs/pref_metrics_service.h View 3 chunks +52 lines, -4 lines 0 comments Download
M trunk/src/chrome/browser/prefs/pref_metrics_service.cc View 5 chunks +228 lines, -14 lines 1 comment Download
A + trunk/src/chrome/browser/prefs/pref_metrics_service_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/chrome/common/pref_names.h View 1 chunk +2 lines, -0 lines 0 comments Download
M trunk/src/chrome/common/pref_names.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M trunk/src/tools/metrics/histograms/histograms.xml View 2 chunks +45 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Vitaly Buka (NO REVIEWS)
7 years, 3 months ago (2013-09-09 04:05:19 UTC) #1
Vitaly Buka (NO REVIEWS)
7 years, 3 months ago (2013-09-09 04:06:13 UTC) #2
Vitaly Buka (NO REVIEWS)
Committed patchset #1 manually as r221972.
7 years, 3 months ago (2013-09-09 04:06:30 UTC) #3
Vitaly Buka (NO REVIEWS)
7 years, 3 months ago (2013-09-09 04:12:11 UTC) #4
Message was sent while issue was closed.
https://codereview.chromium.org/23788010/diff/1/trunk/src/chrome/browser/pref...
File trunk/src/chrome/browser/prefs/pref_metrics_service.cc (right):

https://codereview.chromium.org/23788010/diff/1/trunk/src/chrome/browser/pref...
trunk/src/chrome/browser/prefs/pref_metrics_service.cc:319: // TODO(bbudge) Fix
failing browser_tests and so we can remove this test.
Uhh, I have messed up comment here.
I am not going to fix this to simplify rollback if it would be necessary.

Powered by Google App Engine
This is Rietveld 408576698