Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 23597020: Revert 221944 "Add UMA to report Preferences File Corruption" (Closed)

Created:
7 years, 3 months ago by Vitaly Buka (NO REVIEWS)
Modified:
7 years, 3 months ago
Reviewers:
bbudge
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 221944 "Add UMA to report Preferences File Corruption" Breaks chrome_frame_tests on Win Aura. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Chromium&testType=chrome_frame_tests&builder=Win%20Aura%20Tests%20(1) > Add UMA to report Preferences File Corruption > Adds PrefMetricsService methods to track changes to user preferences > that happen outside of Chrome and report discrepancies via UMA. > > BUG=266569 > > Review URL: https://chromiumcodereview.appspot.com/22676002 TBR=bbudge@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221966

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -610 lines) Patch
M trunk/src/chrome/browser/browser_resources.grd View 1 chunk +0 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/prefs/browser_prefs.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/prefs/pref_metrics_service.h View 3 chunks +4 lines, -52 lines 0 comments Download
M trunk/src/chrome/browser/prefs/pref_metrics_service.cc View 5 chunks +14 lines, -226 lines 0 comments Download
D trunk/src/chrome/browser/prefs/pref_metrics_service_unittest.cc View 1 chunk +0 lines, -274 lines 0 comments Download
M trunk/src/chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/common/pref_names.h View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/chrome/common/pref_names.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M trunk/src/tools/metrics/histograms/histograms.xml View 2 chunks +0 lines, -45 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Vitaly Buka (NO REVIEWS)
7 years, 3 months ago (2013-09-09 00:24:30 UTC) #1
Vitaly Buka (NO REVIEWS)
7 years, 3 months ago (2013-09-09 00:24:49 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r221966.

Powered by Google App Engine
This is Rietveld 408576698