Issue 23788006: WebViewInteractiveTest.Focus flaking on MacOS, Linux

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23788006: WebViewInteractiveTest.Focus flaking on MacOS, Linux (Closed)

Created:
7 years, 3 months ago by rjkroege

Modified:
7 years, 3 months ago

Reviewers:
lazyboy

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

WebViewInteractiveTest.Focus flaking on MacOS, Linux BUG=281815 R=lazyboy@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220673

Patch Set 1 #

Total comments: 1

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -4 lines)			Patch
	M	chrome/browser/apps/web_view_interactive_browsertest.cc	View		1 chunk	+1 line, -4 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

lazyboy

lgtm https://chromiumcodereview.appspot.com/23788006/diff/1/chrome/browser/apps/web_view_interactive_browsertest.cc File chrome/browser/apps/web_view_interactive_browsertest.cc (right): https://chromiumcodereview.appspot.com/23788006/diff/1/chrome/browser/apps/web_view_interactive_browsertest.cc#newcode480 chrome/browser/apps/web_view_interactive_browsertest.cc:480: #define MAYBE_Focus DISABLED_Focus nit: Can get of this ...

7 years, 3 months ago (2013-08-30 22:03:47 UTC) #2

rjkroege

7 years, 3 months ago (2013-08-30 22:06:46 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r220673 (presubmit successful).

Expand Messages | Collapse Messages