Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(939)

Unified Diff: chrome/browser/apps/web_view_interactive_browsertest.cc

Issue 23788006: WebViewInteractiveTest.Focus flaking on MacOS, Linux (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/apps/web_view_interactive_browsertest.cc
diff --git a/chrome/browser/apps/web_view_interactive_browsertest.cc b/chrome/browser/apps/web_view_interactive_browsertest.cc
index 82f68be8d5edfbe24d5aecd88a75278422219450..b53081b773c065ebebc32d9cb8e867589a642cea 100644
--- a/chrome/browser/apps/web_view_interactive_browsertest.cc
+++ b/chrome/browser/apps/web_view_interactive_browsertest.cc
@@ -476,11 +476,8 @@ IN_PROC_BROWSER_TEST_F(WebViewInteractiveTest, PointerLock) {
// Fails on Windows. crbug.com/236040
// Also flaky on ChromiumOS. crbug.com/281815
-#if defined(OS_WIN) || defined(OS_CHROMEOS)
+// Appears to be flaky on Mac and Linux too.
#define MAYBE_Focus DISABLED_Focus
lazyboy 2013/08/30 22:03:47 nit: Can get of this #define and directly call th
-#else
-#define MAYBE_Focus Focus
-#endif
// Tests that setting focus on the <webview> sets focus on the guest.
IN_PROC_BROWSER_TEST_F(WebViewInteractiveTest, MAYBE_Focus) {
ASSERT_TRUE(StartEmbeddedTestServer()); // For serving guest pages.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698