Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(951)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/feedback/FeedbackCollector.java

Issue 2378773010: Expose registered histograms from FeedbackCollector (Closed)
Patch Set: ps Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/feedback/FeedbackCollector.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/feedback/FeedbackCollector.java b/chrome/android/java/src/org/chromium/chrome/browser/feedback/FeedbackCollector.java
index 367923725a0e81d2a9194f4926d89e83fae5d731..1ce132c85c6d40627e2cc397d69cfa93cca54a55 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/feedback/FeedbackCollector.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/feedback/FeedbackCollector.java
@@ -12,6 +12,7 @@ import android.text.TextUtils;
import org.chromium.base.ThreadUtils;
import org.chromium.base.VisibleForTesting;
+import org.chromium.base.metrics.StatisticsRecorderAndroid;
import org.chromium.blimp_public.BlimpClientContext;
import org.chromium.chrome.browser.blimp.BlimpClientContextFactory;
import org.chromium.chrome.browser.net.spdyproxy.DataReductionProxySettings;
@@ -72,6 +73,11 @@ public class FeedbackCollector
private Bitmap mScreenshot;
/**
+ * All the registered histograms as JSON text.
+ */
+ private String mHistograms;
+
+ /**
* A flag indicating whether gathering connection data has finished.
*/
private boolean mConnectivityTaskFinished;
@@ -128,6 +134,9 @@ public class FeedbackCollector
postTimeoutTask();
mConnectivityTask = ConnectivityTask.create(mProfile, CONNECTIVITY_CHECK_TIMEOUT_MS, this);
ScreenshotTask.create(activity, this);
+ if (!mProfile.isOffTheRecord()) {
+ mHistograms = StatisticsRecorderAndroid.toJson();
+ }
}
/**
@@ -232,6 +241,10 @@ public class FeedbackCollector
return mScreenshot;
}
+ public String getHistograms() {
nyquist 2016/10/03 20:55:38 Nit: Add a comment as to what type of data this is
tbansal1 2016/10/04 03:34:11 I added a comment. Let me know if it is insufficie
+ return mHistograms;
+ }
+
/**
* @return the collected data as a {@link Bundle}.
*/

Powered by Google App Engine
This is Rietveld 408576698