Expose registered histograms from FeedbackCollector

Expose registered histograms from FeedbackCollector

The registered histograms on the native side are exposed
as JSON text from the FeedbackCollector. The histograms are
exposed only if:
(i)  "Include screenshot and logs" is checked when
the feedback was collected, and
(ii) The feedback is submitted from a non-incognito
profile.

In the next CL, these would be attached to the feedback
report.

BUG=651621
Committed: https://crrev.com/80c5d05018d8c2ef7a95421e971166175870d050
Cr-Commit-Position: refs/heads/master@{#422765}

[tbansal1, 2016-09-29 23:11:58]

Description was changed from

==========
Expose registered histograms as JSON text from feedback collector

BUG=
==========

to

==========
Expose registered histograms from FeedbackCollector

The registered histograms on the native side are exposed
as JSON text from the FeedbackCollector. The histograms are
exposed only if:
(i)  "Include screenshot and logs" is checked when 
the feedback was collected, and
(ii) The feedback is submitted from a non-incognito 
profile.

In the next CL, these would be attached to the feedback 
report.

BUG=
==========

[tbansal1, 2016-09-29 23:12:16]

Description was changed from

==========
Expose registered histograms from FeedbackCollector

The registered histograms on the native side are exposed
as JSON text from the FeedbackCollector. The histograms are
exposed only if:
(i)  "Include screenshot and logs" is checked when 
the feedback was collected, and
(ii) The feedback is submitted from a non-incognito 
profile.

In the next CL, these would be attached to the feedback 
report.

BUG=
==========

to

==========
Expose registered histograms from FeedbackCollector

The registered histograms on the native side are exposed
as JSON text from the FeedbackCollector. The histograms are
exposed only if:
(i)  "Include screenshot and logs" is checked when 
the feedback was collected, and
(ii) The feedback is submitted from a non-incognito 
profile.

In the next CL, these would be attached to the feedback 
report.

BUG=651621
==========

[tbansal1, 2016-09-29 23:19:08]

Patchset #2 (id:20001) has been deleted

[tbansal1, 2016-09-29 23:19:14]

Patchset #1 (id:1) has been deleted

[tbansal1, 2016-09-29 23:21:58]

Patchset #1 (id:40001) has been deleted

[tbansal1, 2016-09-29 23:22:33]

tbansal@chromium.org changed reviewers:
+ nyquist@chromium.org

[tbansal1, 2016-09-29 23:22:33]

nyquist: ptal.  Thanks.

[tbansal1, 2016-09-29 23:23:11]

On 2016/09/29 23:22:33, tbansal1 wrote:
> nyquist: ptal.  Thanks.

nyquist: //base/android/*. Thanks.

[tbansal1, 2016-09-29 23:23:49]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 23:24:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 00:27:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 00:27:55]

Dry run: This issue passed the CQ dry run.

[nyquist, 2016-10-03 20:55:38]

just nits

https://codereview.chromium.org/2378773010/diff/60001/base/android/java/src/o...
File
base/android/java/src/org/chromium/base/metrics/StatisticsRecorderAndroid.java
(right):

https://codereview.chromium.org/2378773010/diff/60001/base/android/java/src/o...
base/android/java/src/org/chromium/base/metrics/StatisticsRecorderAndroid.java:14:
public class StatisticsRecorderAndroid {
Nit: Should this class be final?

https://codereview.chromium.org/2378773010/diff/60001/base/android/java/src/o...
base/android/java/src/org/chromium/base/metrics/StatisticsRecorderAndroid.java:17:
// Returns all the registered histograms as JSON text.
Nit: Use JavaDoc style (the /** ... */ stuff)

https://codereview.chromium.org/2378773010/diff/60001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/feedback/FeedbackCollector.java
(right):

https://codereview.chromium.org/2378773010/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/feedback/FeedbackCollector.java:244:
public String getHistograms() {
Nit: Add a comment as to what type of data this is. Where does it come from?
What format is it in? Etc.

[tbansal1, 2016-10-04 03:34:11]

nyquist: ptal. Thanks.

https://codereview.chromium.org/2378773010/diff/60001/base/android/java/src/o...
File
base/android/java/src/org/chromium/base/metrics/StatisticsRecorderAndroid.java
(right):

https://codereview.chromium.org/2378773010/diff/60001/base/android/java/src/o...
base/android/java/src/org/chromium/base/metrics/StatisticsRecorderAndroid.java:14:
public class StatisticsRecorderAndroid {
On 2016/10/03 20:55:38, nyquist wrote:
> Nit: Should this class be final?

Done.

https://codereview.chromium.org/2378773010/diff/60001/base/android/java/src/o...
base/android/java/src/org/chromium/base/metrics/StatisticsRecorderAndroid.java:17:
// Returns all the registered histograms as JSON text.
On 2016/10/03 20:55:38, nyquist wrote:
> Nit: Use JavaDoc style (the /** ... */ stuff)

Done.

https://codereview.chromium.org/2378773010/diff/60001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/feedback/FeedbackCollector.java
(right):

https://codereview.chromium.org/2378773010/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/feedback/FeedbackCollector.java:244:
public String getHistograms() {
On 2016/10/03 20:55:38, nyquist wrote:
> Nit: Add a comment as to what type of data this is. Where does it come from?
> What format is it in? Etc.

I added a comment. Let me know if it is insufficient.

[tbansal1, 2016-10-04 03:34:25]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 03:35:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 04:29:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 04:29:40]

Dry run: This issue passed the CQ dry run.

[nyquist, 2016-10-04 06:15:58]

lgtm

[tbansal1, 2016-10-04 12:32:41]

The CQ bit was checked by tbansal@chromium.org

[commit-bot: I haz the power, 2016-10-04 12:32:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 12:37:34]

Description was changed from

==========
Expose registered histograms from FeedbackCollector

The registered histograms on the native side are exposed
as JSON text from the FeedbackCollector. The histograms are
exposed only if:
(i)  "Include screenshot and logs" is checked when 
the feedback was collected, and
(ii) The feedback is submitted from a non-incognito 
profile.

In the next CL, these would be attached to the feedback 
report.

BUG=651621
==========

to

==========
Expose registered histograms from FeedbackCollector

The registered histograms on the native side are exposed
as JSON text from the FeedbackCollector. The histograms are
exposed only if:
(i)  "Include screenshot and logs" is checked when 
the feedback was collected, and
(ii) The feedback is submitted from a non-incognito 
profile.

In the next CL, these would be attached to the feedback 
report.

BUG=651621
==========

[commit-bot: I haz the power, 2016-10-04 12:37:36]

Committed patchset #2 (id:80001)

[commit-bot: I haz the power, 2016-10-04 12:38:57]

Description was changed from

==========
Expose registered histograms from FeedbackCollector

The registered histograms on the native side are exposed
as JSON text from the FeedbackCollector. The histograms are
exposed only if:
(i)  "Include screenshot and logs" is checked when 
the feedback was collected, and
(ii) The feedback is submitted from a non-incognito 
profile.

In the next CL, these would be attached to the feedback 
report.

BUG=651621
==========

to

==========
Expose registered histograms from FeedbackCollector

The registered histograms on the native side are exposed
as JSON text from the FeedbackCollector. The histograms are
exposed only if:
(i)  "Include screenshot and logs" is checked when
the feedback was collected, and
(ii) The feedback is submitted from a non-incognito
profile.

In the next CL, these would be attached to the feedback
report.

BUG=651621

Committed: https://crrev.com/80c5d05018d8c2ef7a95421e971166175870d050
Cr-Commit-Position: refs/heads/master@{#422765}
==========

[commit-bot: I haz the power, 2016-10-04 12:38:58]

Patchset 2 (id:??) landed as
https://crrev.com/80c5d05018d8c2ef7a95421e971166175870d050
Cr-Commit-Position: refs/heads/master@{#422765}