Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(891)

Issue 2378773003: Add version control URI schemes to registerProtocolHandler safelist

Created:
4 years, 2 months ago by joshtriplett
Modified:
3 years, 10 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, haraken, gyuyoung2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add version control URI schemes to registerProtocolHandler safelist This allows sites to register protocol handlers for version control repositories. I've confirmed uses of every one of these schemes in the wild. BUG=651311

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/navigatorcontentutils/register-protocol-handler.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/navigatorcontentutils/unregister-protocol-handler.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp View 2 chunks +28 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
joshtriplett
4 years, 2 months ago (2016-09-29 05:29:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2378773003/1
4 years, 2 months ago (2016-09-30 00:12:13 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 00:12:15 UTC) #7
No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

Powered by Google App Engine
This is Rietveld 408576698