third_party/WebKit/LayoutTests/http/tests/navigatorcontentutils/unregister-protocol-handler.html - Issue 2378773003: Add version control URI schemes to registerProtocolHandler safelist

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/navigatorcontentutils/unregister-protocol-handler.html

Issue 2378773003: Add version control URI schemes to registerProtocolHandler safelist

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/navigatorcontentutils/register-protocol-handler.html ('k') | third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/navigatorcontentutils/unregister-protocol-handler.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/navigatorcontentutils/unregister-protocol-handler.html b/third_party/WebKit/LayoutTests/http/tests/navigatorcontentutils/unregister-protocol-handler.html

index 35109630d1ff7fe46c792152258cec7eea937705..dbefcd4d365f9f86dcad99a392be07d3399e1197 100644

--- a/third_party/WebKit/LayoutTests/http/tests/navigatorcontentutils/unregister-protocol-handler.html

+++ b/third_party/WebKit/LayoutTests/http/tests/navigatorcontentutils/unregister-protocol-handler.html

@@ -30,7 +30,7 @@ invalid_schemes.forEach(function (scheme) {

debug('FAIL Invalid scheme "' + scheme + '" allowed.');

});

-var valid_schemes = ['bitcoin', 'BitcoIn', 'geo', 'im', 'irc', 'Irc', 'ircs', 'magnet', 'MagneT', 'mailto', 'mms', 'news', 'nntp', 'openpgp4fpr', 'sip', 'sms', 'smsto', 'SmsTo', 'ssh', 'tel', 'urn', 'webcal', 'WebCAL', 'wtai', 'WTAI', 'xmpp'];

+var valid_schemes = ['bitcoin', 'BitcoIn', 'geo', 'git', 'git+http', 'git+https', 'git+ssh', 'im', 'irc', 'Irc', 'ircs', 'magnet', 'MagneT', 'mailto', 'mms', 'news', 'nntp', 'openpgp4fpr', 'sip', 'sms', 'smsto', 'SmsTo', 'ssh', 'tel', 'urn', 'webcal', 'WebCAL', 'wtai', 'WTAI', 'xmpp'];

valid_schemes.forEach(function (scheme) {

var succeeded = false;

try {