Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2378753002: Add externalfile: to PDF extension's object-src. (Closed)

Created:
4 years, 2 months ago by fukino
Modified:
4 years, 2 months ago
Reviewers:
raymes
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Add externalfile: to PDF extension's object-src. externalfile:// scheme is used in Chrome OS to open external files (e.g. files in Google Drive) in a browser tab. After https://codereview.chromium.org/2209113002/, we need to specify it in PDF extension's CSP permissions. BUG=645285 TBR=raymes@chromium.org TEST=manually tested the repro steps in the bug description. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2370223002 Cr-Commit-Position: refs/heads/master@{#421447} (cherry picked from commit bbf2420306f6d0a3c85d10a4115ab254b3912162) Committed: https://chromium.googlesource.com/chromium/src/+/b4f6f52b011f0f6a7e30b805934a15e04a644ab8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/pdf/manifest.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
fukino
4 years, 2 months ago (2016-09-28 15:35:36 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b4f6f52b011f0f6a7e30b805934a15e04a644ab8.

Powered by Google App Engine
This is Rietveld 408576698