Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 2370223002: Add externalfile: to PDF extension's object-src. (Closed)

Created:
4 years, 2 months ago by fukino
Modified:
4 years, 2 months ago
Reviewers:
raymes
CC:
chromium-reviews, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add externalfile: to PDF extension's object-src. externalfile:// scheme is used in Chrome OS to open external files (e.g. files in Google Drive) in a browser tab. After https://codereview.chromium.org/2209113002/, we need to specify it in PDF extension's CSP permissions. BUG=645285 TEST=manually tested the repro steps in the bug description. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/bbf2420306f6d0a3c85d10a4115ab254b3912162 Cr-Commit-Position: refs/heads/master@{#421447}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/pdf/manifest.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
fukino
raymes@, could you take a look? Thanks!
4 years, 2 months ago (2016-09-27 10:51:17 UTC) #5
raymes
lgtm
4 years, 2 months ago (2016-09-27 23:48:56 UTC) #6
fukino
Thanks!
4 years, 2 months ago (2016-09-28 04:21:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2370223002/1
4 years, 2 months ago (2016-09-28 04:21:33 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-28 04:34:36 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 04:36:32 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bbf2420306f6d0a3c85d10a4115ab254b3912162
Cr-Commit-Position: refs/heads/master@{#421447}

Powered by Google App Engine
This is Rietveld 408576698