Make GPU configs use kRGBA color type not kN32.

Make GPU configs use kRGBA color type not kN32.

This makes ES msaa contexts testable on systems where kN32 is compiled as kBGRA due to the fact that render buffers are not always supported for GL_BGRA with GL_EXT_texture_format_BGRA8888.

BUG=skia:5804
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2378713002

Committed: https://skia.googlesource.com/skia/+/33069255769246c703e1fbdbe14a752c31d0ad1e

[bsalomon, 2016-09-28 14:10:52]

Description was changed from

==========
Make GPU configs use kRGBA color type not kN32.

This makes ES msaa contexts testable on systems where kN32 is compiled as kBGRA
due to the fact that render buffers are not always supported for GL_BGRA with
GL_EXT_texture_format_BGRA8888.

BUG=skia:5804
==========

to

==========
Make GPU configs use kRGBA color type not kN32.

This makes ES msaa contexts testable on systems where kN32 is compiled as kBGRA
due to the fact that render buffers are not always supported for GL_BGRA with
GL_EXT_texture_format_BGRA8888.

BUG=skia:5804
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2378713002
==========

[bsalomon, 2016-09-28 14:12:13]

bsalomon@google.com changed reviewers:
+ brianosman@google.com

[bsalomon, 2016-09-28 14:12:13]

This works locally for me GM images with configs gpu, msaa4, and angle on
Windows. Also passes unit tests.

[bsalomon, 2016-09-28 14:12:19]

The CQ bit was checked by bsalomon@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-28 14:12:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 14:41:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 14:41:58]

Dry run: This issue passed the CQ dry run.

[Brian Osman, 2016-09-28 15:02:08]

https://codereview.chromium.org/2378713002/diff/1/tools/flags/SkCommonFlagsCo...
File tools/flags/SkCommonFlagsConfig.cpp (right):

https://codereview.chromium.org/2378713002/diff/1/tools/flags/SkCommonFlagsCo...
tools/flags/SkCommonFlagsConfig.cpp:270: *outColorType = kN32_SkColorType;
Want to change here, too?

https://codereview.chromium.org/2378713002/diff/1/tools/flags/SkCommonFlagsCo...
tools/flags/SkCommonFlagsConfig.cpp:310: *outColorType = kN32_SkColorType;
... and here?

[bsalomon, 2016-09-28 15:16:15]

https://codereview.chromium.org/2378713002/diff/1/tools/flags/SkCommonFlagsCo...
File tools/flags/SkCommonFlagsConfig.cpp (right):

https://codereview.chromium.org/2378713002/diff/1/tools/flags/SkCommonFlagsCo...
tools/flags/SkCommonFlagsConfig.cpp:270: *outColorType = kN32_SkColorType;
On 2016/09/28 15:02:07, Brian Osman wrote:
> Want to change here, too?

Ah, I missed this. Done.

https://codereview.chromium.org/2378713002/diff/1/tools/flags/SkCommonFlagsCo...
tools/flags/SkCommonFlagsConfig.cpp:310: *outColorType = kN32_SkColorType;
On 2016/09/28 15:02:07, Brian Osman wrote:
> ... and here?

Done.

[bsalomon, 2016-09-28 15:16:21]

The CQ bit was checked by bsalomon@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-28 15:16:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Brian Osman, 2016-09-28 15:28:16]

lgtm

[commit-bot: I haz the power, 2016-09-28 15:45:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 15:45:41]

Dry run: This issue passed the CQ dry run.

[bsalomon, 2016-09-28 15:48:29]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2016-09-28 15:48:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 15:49:55]

Description was changed from

==========
Make GPU configs use kRGBA color type not kN32.

This makes ES msaa contexts testable on systems where kN32 is compiled as kBGRA
due to the fact that render buffers are not always supported for GL_BGRA with
GL_EXT_texture_format_BGRA8888.

BUG=skia:5804
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2378713002
==========

to

==========
Make GPU configs use kRGBA color type not kN32.

This makes ES msaa contexts testable on systems where kN32 is compiled as kBGRA
due to the fact that render buffers are not always supported for GL_BGRA with
GL_EXT_texture_format_BGRA8888.

BUG=skia:5804
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2378713002

Committed:
https://skia.googlesource.com/skia/+/33069255769246c703e1fbdbe14a752c31d0ad1e
==========

[commit-bot: I haz the power, 2016-09-28 15:49:58]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/33069255769246c703e1fbdbe14a752c31d0ad1e