Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: tools/flags/SkCommonFlagsConfig.cpp

Issue 2378713002: Make GPU configs use kRGBA color type not kN32. (Closed)
Patch Set: fix parsing test Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/TestConfigParsing.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/flags/SkCommonFlagsConfig.cpp
diff --git a/tools/flags/SkCommonFlagsConfig.cpp b/tools/flags/SkCommonFlagsConfig.cpp
index d0e5f60e4f8a082c2f15947c545c2e186949cadb..74db3ee833fd8d45fe65407fee7b1ad201bf6d3b 100644
--- a/tools/flags/SkCommonFlagsConfig.cpp
+++ b/tools/flags/SkCommonFlagsConfig.cpp
@@ -267,7 +267,7 @@ static bool parse_option_gpu_color(const SkString& value,
SkColorType* outColorType,
sk_sp<SkColorSpace>* outColorSpace) {
if (value.equals("8888")) {
- *outColorType = kN32_SkColorType;
+ *outColorType = kRGBA_8888_SkColorType;
*outColorSpace = nullptr;
return true;
}
@@ -307,7 +307,7 @@ static bool parse_option_gpu_color(const SkString& value,
return true;
}
if (commands[0].equals("srgb")) {
- *outColorType = kN32_SkColorType;
+ *outColorType = kRGBA_8888_SkColorType;
*outColorSpace = colorSpace;
return true;
}
@@ -329,7 +329,7 @@ SkCommandLineConfigGpu* parse_command_line_config_gpu(const SkString& tag,
bool seenSamples = false;
int samples = 0;
bool seenColor = false;
- SkColorType colorType = kN32_SkColorType;
+ SkColorType colorType = kRGBA_8888_SkColorType;
sk_sp<SkColorSpace> colorSpace = nullptr;
SkTArray<SkString> optionParts;
« no previous file with comments | « tests/TestConfigParsing.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698