Add CC_LIST and --cc to Gerrit issues via API to be similar to CCs in Rietveld

Add CC_LIST and --cc to Gerrit issues via API to be similar to CCs in Rietveld

BUG=chromium:649660
Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/3574740929abd37c45db1d2f8a2c3799bdfe77c5

[rmistry, 2016-09-28 14:02:49]

The CQ bit was checked by rmistry@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-28 14:03:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 14:08:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 14:08:50]

Dry run: Try jobs failed on following builders:
  Depot Tools Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/3189ef7ec1c68e10)

[rmistry, 2016-09-28 14:42:38]

The CQ bit was checked by rmistry@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-28 14:42:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 14:48:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 14:48:53]

Dry run: Try jobs failed on following builders:
  Depot Tools Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/318a111e0e930e10)

[rmistry, 2016-09-28 15:06:42]

The CQ bit was checked by rmistry@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-28 15:06:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 15:10:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 15:10:01]

Dry run: This issue passed the CQ dry run.

[rmistry, 2016-09-28 15:10:29]

rmistry@google.com changed reviewers:
+ tandrii@chromium.org

[tandrii(chromium), 2016-09-28 15:14:10]

This is awesome. LGTM!

[rmistry, 2016-09-28 15:17:50]

The CQ bit was checked by rmistry@google.com

[commit-bot: I haz the power, 2016-09-28 15:18:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 15:20:58]

Description was changed from

==========
Add CC_LIST and --cc to Gerrit issues via API to be similar to CCs in Rietveld

BUG=chromium:649660
==========

to

==========
Add CC_LIST and --cc to Gerrit issues via API to be similar to CCs in Rietveld

BUG=chromium:649660

Committed:
https://chromium.googlesource.com/chromium/tools/depot_tools/+/3574740929abd3...
==========

[commit-bot: I haz the power, 2016-09-28 15:21:00]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/3574740929abd3...

[tandrii(chromium), 2016-09-29 07:50:48]

This is causing issues if account that is being added as CC-ed is not registered
with Gerrit:

Traceback (most recent call last):
  File "/home/tandrii/bin/depot_tools/git_cl.py", line 5305, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/home/tandrii/bin/depot_tools/git_cl.py", line 5287, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/home/tandrii/bin/depot_tools/subcommand.py", line 252, in execute
    return command(parser, args[1:])
  File "/home/tandrii/bin/depot_tools/git_cl.py", line 3984, in CMDupload
    return cl.CMDUpload(options, args, orig_args)
  File "/home/tandrii/bin/depot_tools/git_cl.py", line 1493, in CMDUpload
    ret = self.CMDUploadChange(options, git_diff_args, change)
  File "/home/tandrii/bin/depot_tools/git_cl.py", line 2666, in CMDUploadChange
    self._GetGerritHost(), self.GetIssue(), cc, is_reviewer=False)
  File "/home/tandrii/bin/depot_tools/gerrit_util.py", line 629, in AddReviewers
    jmsg = ReadHttpJsonResponse(conn, ignore_404=False)
  File "/home/tandrii/bin/depot_tools/gerrit_util.py", line 356, in
ReadHttpJsonResponse
    conn, expect_status=expect_status, ignore_404=ignore_404)
  File "/home/tandrii/bin/depot_tools/gerrit_util.py", line 349, in
ReadHttpResponse
    raise GerritError(response.status, reason)
gerrit_util.GerritError: Unprocessable Entity:  infra-reviews+infra@chromium.org
does not identify a registered user or group

[tandrii(chromium), 2016-09-29 08:40:35]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2375393002/ by tandrii@chromium.org.

The reason for reverting is: Actually, it doesn't break uploads, add cc-ed
emails post-upload fails with exception and confuses users, and I couldn't find
workaround..

[tandrii(chromium), 2016-09-29 11:23:05]

Description was changed from

==========
Add CC_LIST and --cc to Gerrit issues via API to be similar to CCs in Rietveld

BUG=chromium:649660

Committed:
https://chromium.googlesource.com/chromium/tools/depot_tools/+/3574740929abd3...
==========

to

==========
Add CC_LIST and --cc to Gerrit issues via API to be similar to CCs in Rietveld

BUG=chromium:649660

Committed:
https://chromium.googlesource.com/chromium/tools/depot_tools/+/3574740929abd3...
==========

[tandrii(chromium), 2016-09-29 11:23:31]

i found the problem here - whitespace got through in front of email address.
Fixing now.

[tandrii(chromium), 2016-09-29 11:26:54]

Fix is here: https://codereview.chromium.org/2376323002