Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2376323002: Reland of Add CC_LIST and --cc to Gerrit issues via API to be similar to CCs in Rietveld (Closed)

Created:
4 years, 2 months ago by tandrii(chromium)
Modified:
4 years, 2 months ago
Reviewers:
rmistry, rmistry1
CC:
chromium-reviews, tandrii+omg_git_cl_chromium.org, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Reland of Add CC_LIST and --cc to Gerrit issues via API to be similar to CCs in Rietveld Originally landed as issue 2378703002 at patchset 60001 (http://crrev.com/2378703002#ps60001). BUG=chromium:649660 TBR=rmistry@chromium.org Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/8818977467d88125743535010c5b37521694df0a

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -13 lines) Patch
M gerrit_util.py View 2 chunks +5 lines, -2 lines 0 comments Download
M git_cl.py View 2 chunks +10 lines, -7 lines 1 comment Download
M tests/git_cl_test.py View 4 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2376323002/1
4 years, 2 months ago (2016-09-29 11:26:42 UTC) #2
tandrii(chromium)
https://codereview.chromium.org/2376323002/diff/1/git_cl.py File git_cl.py (right): https://codereview.chromium.org/2376323002/diff/1/git_cl.py#newcode2663 git_cl.py:2663: cc = filter(None, [email.strip() for email in cc]) email.strip() ...
4 years, 2 months ago (2016-09-29 11:27:24 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/depot_tools/+/8818977467d88125743535010c5b37521694df0a
4 years, 2 months ago (2016-09-29 11:30:00 UTC) #5
rmistry
4 years, 2 months ago (2016-09-29 11:30:17 UTC) #7
Message was sent while issue was closed.
LGTM

Thanks for the fix!

Powered by Google App Engine
This is Rietveld 408576698