Enable the FileDescriptorWatcher API on TYPE_IO AutoThreads.

Enable the FileDescriptorWatcher API on TYPE_IO AutoThreads.

With this CL, a FileDescriptorWatcher is instantiated on every
remoting::AutoThread that runs a MessageLoopForIO. This allows
FileDescriptorWatcher::WatchReadable/WatchWritable to be used
on these threads.

BUG=645114
Committed: https://crrev.com/968e64e3e26c7fa23b147572b04f5bf91c84a404
Cr-Commit-Position: refs/heads/master@{#422208}

[fdoray, 2016-09-29 14:57:30]

Description was changed from

==========
Enable the FileDescriptorWatcher API on MessageLoopForIO threads.

With this CL, a FileDescriptorWatcher is instantiated on every
base::Thread that runs a MessageLoopForIO. This allows
FileDescriptorWatcher::WatchReadable/WatchWritable to be used
on these threads.

BUG=645114
==========

to

==========
Enable the FileDescriptorWatcher API on TYPE_IO AutoThreads.

With this CL, a FileDescriptorWatcher is instantiated on every
remoting::AutoThread that runs a MessageLoopForIO. This allows
FileDescriptorWatcher::WatchReadable/WatchWritable to be used
on these threads.

BUG=645114
==========

[fdoray, 2016-09-29 14:57:44]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 14:58:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fdoray, 2016-09-29 14:58:28]

fdoray@chromium.org changed reviewers:
+ wez@chromium.org

[fdoray, 2016-09-29 14:58:29]

PTAL

This change is very similar to https://codereview.chromium.org/2372583002

[commit-bot: I haz the power, 2016-09-29 15:03:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 15:03:43]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[fdoray, 2016-09-29 15:06:07]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 15:06:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 15:38:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 15:38:14]

Dry run: This issue passed the CQ dry run.

[fdoray, 2016-09-30 19:23:12]

fdoray@chromium.org changed reviewers:
+ sergeyu@chromium.org

[fdoray, 2016-09-30 19:23:13]

segeyu@: PTAL
(wez OOO)

[Sergey Ulanov, 2016-09-30 19:45:34]

lgtm

[fdoray, 2016-09-30 20:08:01]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2016-09-30 20:08:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 20:34:48]

Description was changed from

==========
Enable the FileDescriptorWatcher API on TYPE_IO AutoThreads.

With this CL, a FileDescriptorWatcher is instantiated on every
remoting::AutoThread that runs a MessageLoopForIO. This allows
FileDescriptorWatcher::WatchReadable/WatchWritable to be used
on these threads.

BUG=645114
==========

to

==========
Enable the FileDescriptorWatcher API on TYPE_IO AutoThreads.

With this CL, a FileDescriptorWatcher is instantiated on every
remoting::AutoThread that runs a MessageLoopForIO. This allows
FileDescriptorWatcher::WatchReadable/WatchWritable to be used
on these threads.

BUG=645114
==========

[commit-bot: I haz the power, 2016-09-30 20:34:48]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-30 20:37:49]

Description was changed from

==========
Enable the FileDescriptorWatcher API on TYPE_IO AutoThreads.

With this CL, a FileDescriptorWatcher is instantiated on every
remoting::AutoThread that runs a MessageLoopForIO. This allows
FileDescriptorWatcher::WatchReadable/WatchWritable to be used
on these threads.

BUG=645114
==========

to

==========
Enable the FileDescriptorWatcher API on TYPE_IO AutoThreads.

With this CL, a FileDescriptorWatcher is instantiated on every
remoting::AutoThread that runs a MessageLoopForIO. This allows
FileDescriptorWatcher::WatchReadable/WatchWritable to be used
on these threads.

BUG=645114

Committed: https://crrev.com/968e64e3e26c7fa23b147572b04f5bf91c84a404
Cr-Commit-Position: refs/heads/master@{#422208}
==========

[commit-bot: I haz the power, 2016-09-30 20:37:50]

Patchset 2 (id:??) landed as
https://crrev.com/968e64e3e26c7fa23b147572b04f5bf91c84a404
Cr-Commit-Position: refs/heads/master@{#422208}

[Wez, 2016-10-04 00:58:06]

https://codereview.chromium.org/2378663006/diff/20001/remoting/base/auto_thre...
File remoting/base/auto_thread.cc (right):

https://codereview.chromium.org/2378663006/diff/20001/remoting/base/auto_thre...
remoting/base/auto_thread.cc:214: if (startup_data_->loop_type ==
base::MessageLoop::TYPE_IO) {
You shouldn't access startup_data_ here, since you just signalled the event to
unlock it.  You either need to move this block before the Signal(), or just use
message_loop.type() here.