Enable the FileDescriptorWatcher API on MessageLoopForIO threads.

Enable the FileDescriptorWatcher API on MessageLoopForIO threads.

With this CL, a FileDescriptorWatcher is instantiated on every
base::Thread that runs a MessageLoopForIO. This allows
FileDescriptorWatcher::WatchReadable/WatchWritable to be used
on these threads.

BUG=645114
Committed: https://crrev.com/fc94b64028d13e4d54038a953038a1c7e3348ed5
Cr-Commit-Position: refs/heads/master@{#421190}

[fdoray, 2016-09-26 14:32:49]

fdoray@chromium.org changed reviewers:
+ dcheng@chromium.org

[fdoray, 2016-09-26 14:32:50]

PTAL

[dcheng, 2016-09-26 17:34:40]

https://codereview.chromium.org/2372583002/diff/40001/base/threading/thread.cc
File base/threading/thread.cc (right):

https://codereview.chromium.org/2372583002/diff/40001/base/threading/thread.c...
base/threading/thread.cc:307: new
FileDescriptorWatcher(MessageLoopForIO::current()));
Is there a time when this wouldn't return the same value as |message_loop_|?

[fdoray, 2016-09-26 17:44:07]

PTAnL

https://codereview.chromium.org/2372583002/diff/40001/base/threading/thread.cc
File base/threading/thread.cc (right):

https://codereview.chromium.org/2372583002/diff/40001/base/threading/thread.c...
base/threading/thread.cc:307: new
FileDescriptorWatcher(MessageLoopForIO::current()));
On 2016/09/26 17:34:40, dcheng wrote:
> Is there a time when this wouldn't return the same value as |message_loop_|?

No.

message_loop_->BindToCurrentThread() above sets the TLS returned by
MessageLoopForIO::current(). Added DCHECK.

[dcheng, 2016-09-26 20:05:35]

On 2016/09/26 17:44:07, fdoray wrote:
> PTAnL
> 
> https://codereview.chromium.org/2372583002/diff/40001/base/threading/thread.cc
> File base/threading/thread.cc (right):
> 
>
https://codereview.chromium.org/2372583002/diff/40001/base/threading/thread.c...
> base/threading/thread.cc:307: new
> FileDescriptorWatcher(MessageLoopForIO::current()));
> On 2016/09/26 17:34:40, dcheng wrote:
> > Is there a time when this wouldn't return the same value as |message_loop_|?
> 
> No.
> 
> message_loop_->BindToCurrentThread() above sets the TLS returned by
> MessageLoopForIO::current(). Added DCHECK.

LGTM, originally I was thinking that we could just pass message_loop_ directly
here, but I guess that won't work without a rather ugly static_cast.

[fdoray, 2016-09-26 20:07:13]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2016-09-26 20:08:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 20:21:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 20:21:38]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[fdoray, 2016-09-27 12:21:20]

The CQ bit was checked by fdoray@chromium.org

[fdoray, 2016-09-27 12:21:20]

The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2372583002/#ps80001
(title: "fix build error")

[commit-bot: I haz the power, 2016-09-27 12:21:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 13:30:00]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-09-27 13:31:29]

Description was changed from

==========
Enable the FileDescriptorWatcher API on MessageLoopForIO threads.

With this CL, a FileDescriptorWatcher is instantiated on every
base::Thread that runs a MessageLoopForIO. This allows
FileDescriptorWatcher::WatchReadable/WatchWritable to be used
on these threads.

BUG=645114
==========

to

==========
Enable the FileDescriptorWatcher API on MessageLoopForIO threads.

With this CL, a FileDescriptorWatcher is instantiated on every
base::Thread that runs a MessageLoopForIO. This allows
FileDescriptorWatcher::WatchReadable/WatchWritable to be used
on these threads.

BUG=645114

Committed: https://crrev.com/fc94b64028d13e4d54038a953038a1c7e3348ed5
Cr-Commit-Position: refs/heads/master@{#421190}
==========

[commit-bot: I haz the power, 2016-09-27 13:31:30]

Patchset 5 (id:??) landed as
https://crrev.com/fc94b64028d13e4d54038a953038a1c7e3348ed5
Cr-Commit-Position: refs/heads/master@{#421190}