[Material] Update Material Security Verbose Decoration Flag

chrome/common/chrome_switches.h

Index: chrome/common/chrome_switches.h
diff --git a/chrome/common/chrome_switches.h b/chrome/common/chrome_switches.h
index 993633d4c853da6a9e7d221af7657d98f2724a55..df14001d67298e45040397cfd51c857270d43196 100644
--- a/chrome/common/chrome_switches.h
+++ b/chrome/common/chrome_switches.h
@@ -183,11 +183,12 @@ extern const char kKioskModePrinting[];
 extern const char kLoadComponentExtension[];
 extern const char kLoadExtension[];
 extern const char kMakeDefaultBrowser[];
-extern const char kMaterialSecurityVerbose[];
-extern const char kMaterialSecurityVerboseShowAllAnimated[];
-extern const char kMaterialSecurityVerboseShowAllNonAnimated[];
-extern const char kMaterialSecurityVerboseShowNonSecureAnimated[];
-extern const char kMaterialSecurityVerboseShowNonSecureNonAnimated[];
+extern const char kSecurityVerboseDecoration[];
+extern const char kSecurityVerboseDecorationShowAllAnimated[];
+extern const char kSecurityVerboseDecorationShowAllNonAnimated[];
+extern const char kSecurityVerboseDecorationShowNonSecureAnimated[];
+extern const char kSecurityVerboseDecorationShowNonSecureNonAnimated[];
+extern const char kSecurityVerboseDecorationShowAllWithOnlyNonSecureAnimated[];

[Peter Kasting, 2016/10/10 21:39:21]

Nit: This name is kinda reaching ridiculous length.  It's resulting in crazy
wrapping at usage sites.  Let's look for shorter names.

One improvement would be to say SecurityChip in place of
SecurityVerboseDecoration.  Neither is terribly meaningful on its own, but the
former is the language we use in various comments and email threads.

Another might be to split this into two flags.  What are we showing, and what
are we animating?  Showing looks to be "all" or "non-secure".  Animating looks
to be "all", "none", or "only non-secure", with the last meaning the same as
"all" if "showing" is set to "non-secure".

This second suggestion also dovetails nicely with my API proposal elsewhere.

[spqchan, 2016/10/11 17:32:58]

Agreed, it's getting ridiculous. I split the flag and renamed it.

 extern const char kMediaCacheSize[];
 extern const char kMediaRouter[];
 extern const char kMetricsRecordingOnly[];