[Material] Update Material Security Verbose Decoration Flag

chrome/common/chrome_switches.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Defines the shared command-line switches used by code in the Chrome
 // directory that don't have anywhere more specific to go.
 
 #ifndef CHROME_COMMON_CHROME_SWITCHES_H_
 #define CHROME_COMMON_CHROME_SWITCHES_H_
 
@@ skipping 165 matching lines @@
 extern const char kInstallChromeApp[];
 extern const char kInstallSupervisedUserWhitelists[];
 extern const char kInstantProcess[];
 extern const char kInterestsURL[];
 extern const char kKeepAliveForTest[];
 extern const char kKioskMode[];
 extern const char kKioskModePrinting[];
 extern const char kLoadComponentExtension[];
 extern const char kLoadExtension[];
 extern const char kMakeDefaultBrowser[];
-extern const char kMaterialSecurityVerbose[];
-extern const char kMaterialSecurityVerboseShowAllAnimated[];
-extern const char kMaterialSecurityVerboseShowAllNonAnimated[];
-extern const char kMaterialSecurityVerboseShowNonSecureAnimated[];
-extern const char kMaterialSecurityVerboseShowNonSecureNonAnimated[];
+extern const char kSecurityVerboseDecoration[];
+extern const char kSecurityVerboseDecorationShowAllAnimated[];
+extern const char kSecurityVerboseDecorationShowAllNonAnimated[];
+extern const char kSecurityVerboseDecorationShowNonSecureAnimated[];
+extern const char kSecurityVerboseDecorationShowNonSecureNonAnimated[];
+extern const char kSecurityVerboseDecorationShowAllWithOnlyNonSecureAnimated[];

[Peter Kasting, 2016/10/10 21:39:21]

Nit: This name is kinda reaching ridiculous length.  It's resulting in crazy
wrapping at usage sites.  Let's look for shorter names.

One improvement would be to say SecurityChip in place of
SecurityVerboseDecoration.  Neither is terribly meaningful on its own, but the
former is the language we use in various comments and email threads.

Another might be to split this into two flags.  What are we showing, and what
are we animating?  Showing looks to be "all" or "non-secure".  Animating looks
to be "all", "none", or "only non-secure", with the last meaning the same as
"all" if "showing" is set to "non-secure".

This second suggestion also dovetails nicely with my API proposal elsewhere.

[spqchan, 2016/10/11 17:32:58]

Agreed, it's getting ridiculous. I split the flag and renamed it.

 extern const char kMediaCacheSize[];
 extern const char kMediaRouter[];
 extern const char kMetricsRecordingOnly[];
 extern const char kMonitoringDestinationID[];
 extern const char kNetLogCaptureMode[];
 extern const char kNoDefaultBrowserCheck[];
 extern const char kNoExperiments[];
 extern const char kNoFirstRun[];
 extern const char kNoPings[];
 extern const char kNoProxyServer[];
@@ skipping 200 matching lines @@
 #if defined(OS_CHROMEOS)
 bool PowerOverlayEnabled();
 #endif
 
 // DON'T ADD RANDOM STUFF HERE. Put it in the main section above in
 // alphabetical order, or in one of the ifdefs (also in order in each section).
 
 }  // namespace switches
 
 #endif  // CHROME_COMMON_CHROME_SWITCHES_H_