gpu/ipc/service/gpu_command_buffer_stub.cc - Issue 2378583003: Ping watchdog thread during GpuChannel destruction

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/ipc/service/gpu_command_buffer_stub.cc

Issue 2378583003: Ping watchdog thread during GpuChannel destruction (Closed)

Patch Set: Fix lifetime and use nullptr Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gpu/ipc/service/gpu_command_buffer_stub.cc

diff --git a/gpu/ipc/service/gpu_command_buffer_stub.cc b/gpu/ipc/service/gpu_command_buffer_stub.cc

index b61e90231121d0cbd6d8dd18e36ef33982d41e9f..6c3063aa446701217dd7816440b705912ac572be 100644

--- a/gpu/ipc/service/gpu_command_buffer_stub.cc

+++ b/gpu/ipc/service/gpu_command_buffer_stub.cc

@@ -469,7 +469,8 @@ bool GpuCommandBufferStub::Initialize(

manager->shader_translator_cache(),

manager->framebuffer_completeness_cache(), feature_info,

init_params.attribs.bind_generates_resource,

- gmb_factory ? gmb_factory->AsImageFactory() : nullptr);

+ gmb_factory ? gmb_factory->AsImageFactory() : nullptr,

+ channel_->watchdog() /* progress_reporter */);

}

#if defined(OS_MACOSX)