gpu/gles2_conform_support/egl/context.cc - Issue 2378583003: Ping watchdog thread during GpuChannel destruction

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/gles2_conform_support/egl/context.cc

Issue 2378583003: Ping watchdog thread during GpuChannel destruction (Closed)

Patch Set: Fix lifetime and use nullptr Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gpu/gles2_conform_support/egl/context.cc

diff --git a/gpu/gles2_conform_support/egl/context.cc b/gpu/gles2_conform_support/egl/context.cc

index 7993e19e992958182f81a7c5861d744dd7139013..001e4979d87d3b206098a190d0184d2fefeaae8a 100644

--- a/gpu/gles2_conform_support/egl/context.cc

+++ b/gpu/gles2_conform_support/egl/context.cc

@@ -259,7 +259,7 @@ bool Context::CreateService(gl::GLSurface* gl_surface) {

scoped_refptr<gpu::gles2::ContextGroup> group(new gpu::gles2::ContextGroup(

gpu_preferences_, nullptr, nullptr,

new gpu::gles2::ShaderTranslatorCache(gpu_preferences_),

- new gpu::gles2::FramebufferCompletenessCache, feature_info, true,

+ new gpu::gles2::FramebufferCompletenessCache, feature_info, true, nullptr,

nullptr));

std::unique_ptr<gpu::gles2::GLES2Decoder> decoder(