gpu/command_buffer/service/shader_manager_unittest.cc - Issue 2378583003: Ping watchdog thread during GpuChannel destruction

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/shader_manager_unittest.cc

Issue 2378583003: Ping watchdog thread during GpuChannel destruction (Closed)

Patch Set: Fix lifetime and use nullptr Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gpu/command_buffer/service/shader_manager_unittest.cc

diff --git a/gpu/command_buffer/service/shader_manager_unittest.cc b/gpu/command_buffer/service/shader_manager_unittest.cc

index 1aef056902255d88f1b2915e5236bb83dcd0b7a3..64b61852f02649519dd145b0b827de849cbefd1b 100644

--- a/gpu/command_buffer/service/shader_manager_unittest.cc

+++ b/gpu/command_buffer/service/shader_manager_unittest.cc

@@ -18,8 +18,7 @@ namespace gles2 {

class ShaderManagerTest : public GpuServiceTest {

public:

- ShaderManagerTest() {

- }

+ ShaderManagerTest() : manager_(nullptr) {}

~ShaderManagerTest() override { manager_.Destroy(false); }