third_party/WebKit/Source/core/testing/DummyPageHolder.h - Issue 2378503002: Observe visibility of password inputs, for HTTP-bad phase 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/testing/DummyPageHolder.h

Issue 2378503002: Observe visibility of password inputs, for HTTP-bad phase 1 (Closed)

Patch Set: fix browser-side binding Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/password_manager/DEPS ('K') | « third_party/WebKit/Source/core/html/forms/PasswordInputTypeTest.cpp ('k') | third_party/WebKit/Source/core/testing/DummyPageHolder.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/testing/DummyPageHolder.h

diff --git a/third_party/WebKit/Source/core/testing/DummyPageHolder.h b/third_party/WebKit/Source/core/testing/DummyPageHolder.h

index fa340410fbc87b776bcd4642355bce29f66d3da1..7f12405bba9c0e73fe7d60e4a11f27829c366b41 100644

--- a/third_party/WebKit/Source/core/testing/DummyPageHolder.h

+++ b/third_party/WebKit/Source/core/testing/DummyPageHolder.h

@@ -44,6 +44,7 @@ namespace blink {

class Document;

class LocalFrame;

class FrameView;

+class InterfaceProvider;

class IntSize;

class Settings;

@@ -66,7 +67,7 @@ public:

const IntSize& initialViewSize = IntSize(),

Page::PageClients* = 0,

FrameLoaderClient* = nullptr,

- FrameSettingOverrideFunction = nullptr);

+ FrameSettingOverrideFunction = nullptr, InterfaceProvider* = nullptr);

~DummyPageHolder();

Page& page() const;

@@ -75,7 +76,7 @@ public:

Document& document() const;

private:

- DummyPageHolder(const IntSize& initialViewSize, Page::PageClients*, FrameLoaderClient*, FrameSettingOverrideFunction settingOverrider);

+ DummyPageHolder(const IntSize& initialViewSize, Page::PageClients*, FrameLoaderClient*, FrameSettingOverrideFunction settingOverrider, InterfaceProvider* = nullptr);

Persistent<Page> m_page;

Persistent<LocalFrame> m_frame;