Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Unified Diff: third_party/WebKit/Source/core/testing/DummyPageHolder.cpp

Issue 2378503002: Observe visibility of password inputs, for HTTP-bad phase 1 (Closed)
Patch Set: fix browser-side binding Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/testing/DummyPageHolder.cpp
diff --git a/third_party/WebKit/Source/core/testing/DummyPageHolder.cpp b/third_party/WebKit/Source/core/testing/DummyPageHolder.cpp
index 092818685529ba26544d4b2fe41fd7cb622d5c76..860f6a5f9c249dd5a446d61728a1a79b75c11ac9 100644
--- a/third_party/WebKit/Source/core/testing/DummyPageHolder.cpp
+++ b/third_party/WebKit/Source/core/testing/DummyPageHolder.cpp
@@ -47,15 +47,16 @@ std::unique_ptr<DummyPageHolder> DummyPageHolder::create(
const IntSize& initialViewSize,
Page::PageClients* pageClients,
FrameLoaderClient* frameLoaderClient,
- FrameSettingOverrideFunction settingOverrider) {
- return wrapUnique(new DummyPageHolder(initialViewSize, pageClients, frameLoaderClient, settingOverrider));
+ FrameSettingOverrideFunction settingOverrider, InterfaceProvider* interfaceProvider)
+{
+ return wrapUnique(new DummyPageHolder(initialViewSize, pageClients, frameLoaderClient, settingOverrider, interfaceProvider));
}
DummyPageHolder::DummyPageHolder(
const IntSize& initialViewSize,
Page::PageClients* pageClientsArgument,
FrameLoaderClient* frameLoaderClient,
- FrameSettingOverrideFunction settingOverrider)
+ FrameSettingOverrideFunction settingOverrider, InterfaceProvider* interfaceProvider)
{
Page::PageClients pageClients;
if (!pageClientsArgument) {
@@ -78,7 +79,7 @@ DummyPageHolder::DummyPageHolder(
if (!m_frameLoaderClient)
m_frameLoaderClient = EmptyFrameLoaderClient::create();
- m_frame = LocalFrame::create(m_frameLoaderClient.get(), &m_page->frameHost(), nullptr);
+ m_frame = LocalFrame::create(m_frameLoaderClient.get(), &m_page->frameHost(), nullptr, interfaceProvider);
m_frame->setView(FrameView::create(m_frame.get(), initialViewSize));
m_frame->view()->page()->frameHost().visualViewport().setSize(initialViewSize);
m_frame->init();

Powered by Google App Engine
This is Rietveld 408576698