Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Unified Diff: components/password_manager/content/browser/content_password_manager_driver.cc

Issue 2378503002: Observe visibility of password inputs, for HTTP-bad phase 1 (Closed)
Patch Set: rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/content/browser/content_password_manager_driver.cc
diff --git a/components/password_manager/content/browser/content_password_manager_driver.cc b/components/password_manager/content/browser/content_password_manager_driver.cc
index 9f2bc1fbc72d6e11fd3b035ac5c180796ba3b2dd..c9854058af8dbb3a1117971df55cf8ae39e39ec3 100644
--- a/components/password_manager/content/browser/content_password_manager_driver.cc
+++ b/components/password_manager/content/browser/content_password_manager_driver.cc
@@ -49,7 +49,7 @@ ContentPasswordManagerDriver::ContentPasswordManagerDriver(
password_generation_manager_(client, this),
password_autofill_manager_(this, autofill_client),
next_free_key_(0),
- binding_(this),
+ password_manager_binding_(this),
weak_factory_(this) {}
ContentPasswordManagerDriver::~ContentPasswordManagerDriver() {
@@ -67,7 +67,12 @@ ContentPasswordManagerDriver::GetForRenderFrameHost(
void ContentPasswordManagerDriver::BindRequest(
autofill::mojom::PasswordManagerDriverRequest request) {
- binding_.Bind(std::move(request));
+ password_manager_binding_.Bind(std::move(request));
+}
+
+void ContentPasswordManagerDriver::BindSensitiveInputVisibilityServiceRequest(
+ blink::mojom::SensitiveInputVisibilityServiceRequest request) {
+ sensitive_input_visibility_bindings_.AddBinding(this, std::move(request));
}
void ContentPasswordManagerDriver::FillPasswordForm(
@@ -203,6 +208,12 @@ void ContentPasswordManagerDriver::OnFocusedPasswordFormFound(
GetPasswordManager()->OnPasswordFormForceSaveRequested(this, password_form);
}
+void ContentPasswordManagerDriver::PasswordFieldVisibleInInsecureContext() {
+ // TODO(estark): notify the WebContents that a password field was
+ // shown, which will downgrade the security UI
+ // appropriately. https://crbug.com/647560
+}
+
void ContentPasswordManagerDriver::DidNavigateFrame(
const content::LoadCommittedDetails& details,
const content::FrameNavigateParams& params) {

Powered by Google App Engine
This is Rietveld 408576698