Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Unified Diff: components/password_manager/content/browser/content_password_manager_driver.h

Issue 2378503002: Observe visibility of password inputs, for HTTP-bad phase 1 (Closed)
Patch Set: rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/content/browser/content_password_manager_driver.h
diff --git a/components/password_manager/content/browser/content_password_manager_driver.h b/components/password_manager/content/browser/content_password_manager_driver.h
index e4ed94cd1210fa1935b1dbcaf839ac4e528e4ea5..fe69589950fa6b8b3fcb7f527b860bb28df87ec6 100644
--- a/components/password_manager/content/browser/content_password_manager_driver.h
+++ b/components/password_manager/content/browser/content_password_manager_driver.h
@@ -19,6 +19,8 @@
#include "components/password_manager/core/browser/password_manager.h"
#include "components/password_manager/core/browser/password_manager_driver.h"
#include "mojo/public/cpp/bindings/binding.h"
+#include "mojo/public/cpp/bindings/binding_set.h"
+#include "third_party/WebKit/public/platform/modules/sensitive_input_visibility/sensitive_input_visibility_service.mojom.h"
namespace autofill {
class AutofillManager;
@@ -43,7 +45,8 @@ enum class BadMessageReason;
// The lifetime is managed by the ContentPasswordManagerDriverFactory.
class ContentPasswordManagerDriver
: public PasswordManagerDriver,
- public autofill::mojom::PasswordManagerDriver {
+ public autofill::mojom::PasswordManagerDriver,
+ public blink::mojom::SensitiveInputVisibilityService {
public:
ContentPasswordManagerDriver(content::RenderFrameHost* render_frame_host,
PasswordManagerClient* client,
@@ -55,6 +58,8 @@ class ContentPasswordManagerDriver
content::RenderFrameHost* render_frame_host);
void BindRequest(autofill::mojom::PasswordManagerDriverRequest request);
+ void BindSensitiveInputVisibilityServiceRequest(
+ blink::mojom::SensitiveInputVisibilityServiceRequest request);
// PasswordManagerDriver implementation.
void FillPasswordForm(
@@ -115,6 +120,9 @@ class ContentPasswordManagerDriver
const std::vector<autofill::PasswordForm>& forms);
void OnFocusedPasswordFormFound(const autofill::PasswordForm& password_form);
+ // blink::mojom::SensitiveInputVisibility:
+ void PasswordFieldVisibleInInsecureContext() override;
+
private:
bool CheckChildProcessSecurityPolicy(const GURL& url,
BadMessageReason reason);
@@ -141,7 +149,10 @@ class ContentPasswordManagerDriver
autofill::mojom::PasswordGenerationAgentPtr password_gen_agent_;
- mojo::Binding<autofill::mojom::PasswordManagerDriver> binding_;
+ mojo::Binding<autofill::mojom::PasswordManagerDriver>
+ password_manager_binding_;
+ mojo::BindingSet<blink::mojom::SensitiveInputVisibilityService>
+ sensitive_input_visibility_bindings_;
base::WeakPtrFactory<ContentPasswordManagerDriver> weak_factory_;

Powered by Google App Engine
This is Rietveld 408576698