Index: chrome/browser/ui/views/color_chooser_win.cc |
diff --git a/chrome/browser/ui/views/color_chooser_win.cc b/chrome/browser/ui/views/color_chooser_win.cc |
index b895c5e2b6e621ecbf8460d00a3757cef85fea6b..f1eb05c8cca0eee45baf0b52a10b8ada39497cba 100644 |
--- a/chrome/browser/ui/views/color_chooser_win.cc |
+++ b/chrome/browser/ui/views/color_chooser_win.cc |
@@ -24,7 +24,7 @@ class ColorChooserWin : public content::ColorChooser, |
~ColorChooserWin(); |
// content::ColorChooser overrides: |
- virtual void End() OVERRIDE {} |
+ virtual void End() OVERRIDE; |
virtual void SetSelectedColor(SkColor color) OVERRIDE {} |
// views::ColorChooserListener overrides: |
@@ -66,6 +66,16 @@ ColorChooserWin::~ColorChooserWin() { |
DCHECK(!color_chooser_dialog_); |
} |
+void ColorChooserWin::End() { |
+ // The ColorChooserDialog's listener is going away. Ideally we'd |
+ // programmatically close the dialog at this point. Since that's impossible, |
+ // we instead tell the dialog its listener is going away, so that the dialog |
+ // doesn't try to communicate with a destroyed listener later. (We also tell |
+ // the renderer the dialog is closed, since from the renderer's perspective |
+ // it effectively is.) |
+ OnColorChooserDialogClosed(); |
+} |
+ |
void ColorChooserWin::OnColorChosen(SkColor color) { |
if (web_contents_) |
web_contents_->DidChooseColorInColorChooser(color); |