Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2378423003: Fix some errors around []= in core types. (Closed)

Created:
4 years, 2 months ago by Bob Nystrom
Modified:
4 years, 2 months ago
Reviewers:
vsm, Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix some errors around []= in core types. - Get rid of JSMutableIndexable since it isn't useful. - Make JSIndexable generic. (I think dart2js already did.) - Add .length to NativeTypedArray since it no longer inherits it from JavaScriptIndexingBehavior. R=jmesserly@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/2c313a43acea9315019943f2341dbf4601e4b9e8

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -57 lines) Patch
M pkg/dev_compiler/lib/js/amd/dart_sdk.js View 7 chunks +12 lines, -6 lines 0 comments Download
M pkg/dev_compiler/lib/js/common/dart_sdk.js View 7 chunks +12 lines, -6 lines 0 comments Download
M pkg/dev_compiler/lib/js/es6/dart_sdk.js View 7 chunks +12 lines, -6 lines 0 comments Download
M pkg/dev_compiler/lib/js/legacy/dart_sdk.js View 7 chunks +12 lines, -6 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/interceptors.dart View 1 chunk +2 lines, -11 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/js_array.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/js_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/js_string.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/native_typed_data.dart View 1 chunk +1 line, -2 lines 2 comments Download
M pkg/dev_compiler/tool/sdk_expected_errors.txt View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Bob Nystrom
https://codereview.chromium.org/2378423003/diff/1/pkg/dev_compiler/tool/input_sdk/private/native_typed_data.dart File pkg/dev_compiler/tool/input_sdk/private/native_typed_data.dart (right): https://codereview.chromium.org/2378423003/diff/1/pkg/dev_compiler/tool/input_sdk/private/native_typed_data.dart#newcode755 pkg/dev_compiler/tool/input_sdk/private/native_typed_data.dart:755: int get length; Is it OK to add this ...
4 years, 2 months ago (2016-09-30 00:09:15 UTC) #2
Jennifer Messerly
LGTM! https://codereview.chromium.org/2378423003/diff/1/pkg/dev_compiler/tool/input_sdk/private/native_typed_data.dart File pkg/dev_compiler/tool/input_sdk/private/native_typed_data.dart (right): https://codereview.chromium.org/2378423003/diff/1/pkg/dev_compiler/tool/input_sdk/private/native_typed_data.dart#newcode755 pkg/dev_compiler/tool/input_sdk/private/native_typed_data.dart:755: int get length; On 2016/09/30 00:09:15, Bob Nystrom ...
4 years, 2 months ago (2016-09-30 00:11:07 UTC) #3
Bob Nystrom
4 years, 2 months ago (2016-09-30 20:03:18 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2c313a43acea9315019943f2341dbf4601e4b9e8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698