pkg/dev_compiler/tool/input_sdk/private/native_typed_data.dart - Issue 2378423003: Fix some errors around []= in core types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/dev_compiler/tool/input_sdk/private/native_typed_data.dart

Issue 2378423003: Fix some errors around []= in core types. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/dev_compiler/tool/input_sdk/private/native_typed_data.dart

diff --git a/pkg/dev_compiler/tool/input_sdk/private/native_typed_data.dart b/pkg/dev_compiler/tool/input_sdk/private/native_typed_data.dart

index 40c3f767c299131a722dd8830310a20d9aeefa07..d823c36d157d42de34c95a03cb2ac7428eaf79ad 100644

--- a/pkg/dev_compiler/tool/input_sdk/private/native_typed_data.dart

+++ b/pkg/dev_compiler/tool/input_sdk/private/native_typed_data.dart

@@ -752,8 +752,7 @@ class NativeByteData extends NativeTypedData implements ByteData {

abstract class NativeTypedArray extends NativeTypedData

implements JavaScriptIndexingBehavior {

- // TODO(jmesserly): moved `length` to subclass to (somewhat) mitigate

- // <https://github.com/dart-lang/dev_compiler/issues/138>

+ int get length;

Bob Nystrom 2016/09/30 00:09:15 Is it OK to add this here, or will it re-trigger #

Jennifer Messerly 2016/09/30 00:11:07 it should be safe now. Definitely if you didn't se

void _setRangeFast(int start, int end,

NativeTypedArray source, int skipCount) {