Mac: Fix Sierra solid color layer color-mismatch

Mac: Fix Sierra solid color layer color-mismatch

Sierra treats the color correction of IOSurface-backed layers and solid
color layers differently. To ensure that behavior is consistent, do not
use solid color layers, rather, in such cases, use an 16x16 IOSurface
that is initialized to the solid color.

BUG=633805
Committed: https://crrev.com/318395caaf3a43683a41d09e65050649d5fedf27
Cr-Commit-Position: refs/heads/master@{#421899}

[ccameron, 2016-09-29 05:17:20]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 05:17:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ccameron, 2016-09-29 05:21:29]

ccameron@chromium.org changed reviewers:
+ erikchen@chromium.org

[ccameron, 2016-09-29 05:21:29]

Note that this doesn't use a GPU bug workaround because it may need a merge into
M53 (which could be hairy with that). If we stick with this long-term, I'll
switch to the usual workaround format.

Because it looks like they've deprecated our remote layer path in 10.12, I think
we should just give up on remote layers and host everything in the browser. I
have some ideas of how to do this non-intrusively.

[commit-bot: I haz the power, 2016-09-29 05:48:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 05:48:01]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ccameron, 2016-09-29 17:23:34]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 17:23:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 18:19:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 18:19:53]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[erikchen, 2016-09-29 18:23:27]

lgtm

https://codereview.chromium.org/2378423002/diff/20001/ui/accelerated_widget_m...
File ui/accelerated_widget_mac/ca_renderer_layer_tree.mm (right):

https://codereview.chromium.org/2378423002/diff/20001/ui/accelerated_widget_m...
ui/accelerated_widget_mac/ca_renderer_layer_tree.mm:169:
IOSurfaceLock(io_surface, 0, NULL);
s/NULL/nullptr

https://codereview.chromium.org/2378423002/diff/20001/ui/accelerated_widget_m...
ui/accelerated_widget_mac/ca_renderer_layer_tree.mm:368: if
(base::mac::IsAtLeastOS10_12()) {
IWYU

[erikchen, 2016-09-29 18:24:06]

On 2016/09/29 05:21:29, ccameron wrote:
> Note that this doesn't use a GPU bug workaround because it may need a merge
into
> M53 (which could be hairy with that). If we stick with this long-term, I'll
> switch to the usual workaround format.
> 
> Because it looks like they've deprecated our remote layer path in 10.12, I
think
> we should just give up on remote layers and host everything in the browser. I
> have some ideas of how to do this non-intrusively.

I'm not sure I agree with this, since we'll want to move it for the MUS refactor
anyways. Happy to discuss further offline.

[ccameron, 2016-09-29 18:54:15]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 18:54:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ccameron, 2016-09-29 19:20:51]

Thanks!

[ccameron, 2016-09-29 19:20:56]

The CQ bit was unchecked by ccameron@chromium.org

[ccameron, 2016-09-29 19:21:09]

The CQ bit was checked by ccameron@chromium.org

[ccameron, 2016-09-29 19:21:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
erikchen@chromium.org
Link to the patchset: https://codereview.chromium.org/2378423002/#ps40001
(title: "Fix includes")

[commit-bot: I haz the power, 2016-09-29 19:21:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 19:30:16]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-29 19:34:38]

Description was changed from

==========
Mac: Fix Sierra solid color layer color-mismatch

Sierra treats the color correction of IOSurface-backed layers and solid
color layers differently. To ensure that behavior is consistent, do not
use solid color layers, rather, in such cases, use an 16x16 IOSurface
that is initialized to the solid color.

BUG=633805
==========

to

==========
Mac: Fix Sierra solid color layer color-mismatch

Sierra treats the color correction of IOSurface-backed layers and solid
color layers differently. To ensure that behavior is consistent, do not
use solid color layers, rather, in such cases, use an 16x16 IOSurface
that is initialized to the solid color.

BUG=633805

Committed: https://crrev.com/318395caaf3a43683a41d09e65050649d5fedf27
Cr-Commit-Position: refs/heads/master@{#421899}
==========

[commit-bot: I haz the power, 2016-09-29 19:34:39]

Patchset 3 (id:??) landed as
https://crrev.com/318395caaf3a43683a41d09e65050649d5fedf27
Cr-Commit-Position: refs/heads/master@{#421899}