Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 2378163003: Use brackets for explicit GPU config params in tools (Closed)

Created:
4 years, 2 months ago by bsalomon
Modified:
4 years, 2 months ago
Reviewers:
Brian Osman
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Use brackets for explicit GPU config params in tools GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2378163003 Committed: https://skia.googlesource.com/skia/+/808ecbb13578ada75e01fae0ff574b3a12df48a5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -33 lines) Patch
M tests/TestConfigParsing.cpp View 5 chunks +28 lines, -28 lines 0 comments Download
M tools/flags/SkCommonFlagsConfig.cpp View 4 chunks +5 lines, -5 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
bsalomon
4 years, 2 months ago (2016-09-28 18:52:40 UTC) #3
Brian Osman
lgtm
4 years, 2 months ago (2016-09-28 19:10:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2378163003/1
4 years, 2 months ago (2016-09-28 19:18:50 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 19:40:25 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/808ecbb13578ada75e01fae0ff574b3a12df48a5

Powered by Google App Engine
This is Rietveld 408576698