Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2378113005: Change isCSSWideKeyword() to take a StringView instead of a CSSValueID (Closed)

Created:
4 years, 2 months ago by Timothy Loh
Modified:
4 years, 2 months ago
Reviewers:
nainar
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change isCSSWideKeyword() to take a StringView instead of a CSSValueID This patch changes the isCSSWideKeyword function to take a StringView instead of a CSSValueID. Currently all its (two) callers just have a CSSParserToken so it seems more efficient to just do string comparisons instead of hashing the string into a CSSValueID first. A subsequent patch will use this function in CSSSyntaxDescriptor.cpp where we will only have a string and making a CSSValueID for that seems wrong. Committed: https://crrev.com/692c9aef14c0699ef68a6796b68c93df69b4e731 Cr-Commit-Position: refs/heads/master@{#422004}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -7 lines) Patch
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.h View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp View 2 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
Timothy Loh
4 years, 2 months ago (2016-09-29 09:36:25 UTC) #4
nainar
lgtm
4 years, 2 months ago (2016-09-29 23:19:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2378113005/1
4 years, 2 months ago (2016-09-30 00:35:58 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-30 01:14:07 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 01:16:12 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/692c9aef14c0699ef68a6796b68c93df69b4e731
Cr-Commit-Position: refs/heads/master@{#422004}

Powered by Google App Engine
This is Rietveld 408576698