Issue 2378113004: Some kernel->ssa cleanups.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2378113004: Some kernel->ssa cleanups. (Closed)

Created:
4 years, 2 months ago by Harry Terkelsen

Modified:
4 years, 2 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Some kernel->ssa cleanups. * add --disable-inlining flag to top-level command for testing * merge pushCheckNull into GraphBuilder now that compiler is in there * fix typo R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/a56cf2cac4731fce6ef9393b9ff4663f7765993a

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -25 lines)			Patch
M	pkg/compiler/lib/src/dart2js.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	pkg/compiler/lib/src/ssa/builder.dart	View		3 chunks	+4 lines, -10 lines	0 comments	Download
M	pkg/compiler/lib/src/ssa/builder_kernel.dart	View		3 chunks	+11 lines, -13 lines	0 comments	Download
M	pkg/compiler/lib/src/ssa/graph_builder.dart	View	1	3 chunks	+8 lines, -2 lines	0 comments	Download

Total messages: 5 (2 generated)

Harry Terkelsen

4 years, 2 months ago (2016-09-28 19:40:05 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
a56cf2cac4731fce6ef9393b9ff4663f7765993a (presubmit successful).