Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Unified Diff: pkg/compiler/lib/src/ssa/builder.dart

Issue 2378113004: Some kernel->ssa cleanups. (Closed)
Patch Set: fix import Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/dart2js.dart ('k') | pkg/compiler/lib/src/ssa/builder_kernel.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/ssa/builder.dart
diff --git a/pkg/compiler/lib/src/ssa/builder.dart b/pkg/compiler/lib/src/ssa/builder.dart
index a980869a9c1fdf33cbe22c05b0bcf4bfa9730b1a..fd895189164b344f6c0fa385c12c980488ee1b94 100644
--- a/pkg/compiler/lib/src/ssa/builder.dart
+++ b/pkg/compiler/lib/src/ssa/builder.dart
@@ -913,14 +913,14 @@ class SsaBuilder extends ast.Visitor
* Invariant: [constructors] must contain only implementation elements.
*/
void inlineSuperOrRedirect(
- ResolvedAst constructorRecolvedAst,
+ ResolvedAst constructorResolvedAst,
List<HInstruction> compiledArguments,
List<ResolvedAst> constructorResolvedAsts,
Map<Element, HInstruction> fieldValues,
FunctionElement caller) {
- ConstructorElement callee = constructorRecolvedAst.element.implementation;
+ ConstructorElement callee = constructorResolvedAst.element.implementation;
reporter.withCurrentElement(callee, () {
- constructorResolvedAsts.add(constructorRecolvedAst);
+ constructorResolvedAsts.add(constructorResolvedAst);
ClassElement enclosingClass = callee.enclosingClass;
if (backend.classNeedsRti(enclosingClass)) {
// If [enclosingClass] needs RTI, we have to give a value to its
@@ -958,7 +958,7 @@ class SsaBuilder extends ast.Visitor
// For redirecting constructors, the fields will be initialized later
// by the effective target.
if (!callee.isRedirectingGenerative) {
- inlinedFrom(constructorRecolvedAst, () {
+ inlinedFrom(constructorResolvedAst, () {
buildFieldInitializers(
callee.enclosingClass.implementation, fieldValues);
});
@@ -2308,12 +2308,6 @@ class SsaBuilder extends ast.Visitor
}
@override
- pushCheckNull(HInstruction expression) {
- push(new HIdentity(
- expression, graph.addConstantNull(compiler), null, backend.boolType));
- }
-
- @override
void visitLocalVariableGet(ast.Send node, LocalVariableElement variable, _) {
handleLocalGet(node, variable);
}
« no previous file with comments | « pkg/compiler/lib/src/dart2js.dart ('k') | pkg/compiler/lib/src/ssa/builder_kernel.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698