Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Issue 23781011: ninja/mac: Insert a few synthesized Info.plist entries. (Closed)

Created:
7 years, 3 months ago by Nico
Modified:
7 years, 3 months ago
Reviewers:
scottmg
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

ninja/mac: Insert a few synthesized Info.plist entries. Namely, insert BuildMachineOSBuild, DTSDKName, DTSDKBuild, DTXcode, DTXcodeBuild The values for the synthesized keys are collected at gyp time. The logic for this is in XcodeEmulation, which makes it add support for this to the make generator too if someone feels motivated. The `mac_tool copy-info-plist` command grows support for an arbitrary number of [key value] arguments, and these values blindly overwrite potential existing entries from the plist file (this matches Xcode). BUG=280718 R=scottmg@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=1734

Patch Set 1 #

Patch Set 2 : #

Total comments: 3

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -17 lines) Patch
M pylib/gyp/generator/ninja.py View 1 2 chunks +13 lines, -7 lines 0 comments Download
M pylib/gyp/mac_tool.py View 1 1 chunk +6 lines, -1 line 0 comments Download
M pylib/gyp/xcode_emulation.py View 1 2 3 4 5 6 7 4 chunks +52 lines, -8 lines 0 comments Download
M test/mac/app-bundle/TestApp/TestApp-Info.plist View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M test/mac/gyptest-app.py View 1 2 3 4 5 6 7 2 chunks +29 lines, -0 lines 0 comments Download
M test/mac/gyptest-sdkroot.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
Several "neat" python tricks in this cl! https://codereview.chromium.org/23781011/diff/3001/pylib/gyp/xcode_emulation.py File pylib/gyp/xcode_emulation.py (left): https://codereview.chromium.org/23781011/diff/3001/pylib/gyp/xcode_emulation.py#oldcode259 pylib/gyp/xcode_emulation.py:259: sdk_root = ...
7 years, 3 months ago (2013-09-17 22:03:49 UTC) #1
scottmg
"neat" indeed lgtm https://codereview.chromium.org/23781011/diff/3001/test/mac/gyptest-app.py File test/mac/gyptest-app.py (right): https://codereview.chromium.org/23781011/diff/3001/test/mac/gyptest-app.py#newcode60 test/mac/gyptest-app.py:60: xcode = xcode.split()[-1].replace('.', '').zfill(4) On 2013/09/17 ...
7 years, 3 months ago (2013-09-17 22:27:44 UTC) #2
Nico
Thanks! (The trybots were less kind, so I had to tweak this slightly.)
7 years, 3 months ago (2013-09-17 23:41:52 UTC) #3
Nico
7 years, 3 months ago (2013-09-17 23:43:31 UTC) #4
Message was sent while issue was closed.
Committed patchset #8 manually as r1734 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698