ninja/mac: Insert a few synthesized Info.plist entries.

test/mac/gyptest-app.py

 #!/usr/bin/env python
 
 # Copyright (c) 2012 Google Inc. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """
 Verifies that app bundles are built correctly.
 """
 
 import TestGyp
 
 import os
+import plistlib
+import subprocess
 import sys
 
+def GetStdout(cmdlist):
+  return subprocess.Popen(cmdlist,
+                          stdout=subprocess.PIPE).communicate()[0].rstrip('\n')
 
 def ls(path):
   '''Returns a list of all files in a directory, relative to the directory.'''
   result = []
   for dirpath, _, files in os.walk(path):
     for f in files:
       result.append(os.path.join(dirpath, f)[len(path) + 1:])
   return result
 
 
 if sys.platform == 'darwin':
   test = TestGyp.TestGyp(formats=['ninja', 'make', 'xcode'])
 
   test.run_gyp('test.gyp', chdir='app-bundle')
 
   test.build('test.gyp', test.ALL, chdir='app-bundle')
 
   # Binary
   test.built_file_must_exist('Test App Gyp.app/Contents/MacOS/Test App Gyp',
                              chdir='app-bundle')
 
   # Info.plist
   info_plist = test.built_file_path('Test App Gyp.app/Contents/Info.plist',
                                     chdir='app-bundle')
   test.must_exist(info_plist)
   test.must_contain(info_plist, 'com.google.Test-App-Gyp')  # Variable expansion
   test.must_not_contain(info_plist, '${MACOSX_DEPLOYMENT_TARGET}');
 
+  if test.format != 'make':
+    # TODO: Synthesized plist entries aren't hooked up in the make generator.
+    plist = plistlib.readPlist(info_plist)
+    if plist['BuildMachineOSBuild'] != GetStdout(['sw_vers', '-buildVersion']):
+      test.fail_test()
+    if plist['DTSDKName'] != '':
+      test.fail_test()
+    if plist['DTSDKBuild'] != GetStdout(
+        ['xcodebuild', '-version', '-sdk', '', 'ProductBuildVersion']):
+      test.fail_test()
+    xcode, build = GetStdout(['xcodebuild', '-version']).splitlines()
+    xcode = xcode.split()[-1].replace('.', '').zfill(4)

[Nico, 2013/09/17 22:03:49]

It might seem silly to have the same test here as in xcode_emulation, but this
checks that the code matches xcode's behavior too.

[scottmg, 2013/09/17 22:27:44]

Oh, I thought maybe that was a first
https://code.google.com/p/chromium/codesearch#search/&q=zfill%20file:.py%20-t....
Very useful batteries included!

+    build = build.split()[-1]
+    if plist['DTXcode'] != xcode:
+      test.fail_test()
+    if plist['DTXcodeBuild'] != build:
+      test.fail_test()
+
   # Resources
   strings_files = ['InfoPlist.strings', 'utf-16be.strings', 'utf-16le.strings']
   for f in strings_files:
     strings = test.built_file_path(
         os.path.join('Test App Gyp.app/Contents/Resources/English.lproj', f),
         chdir='app-bundle')
     test.must_exist(strings)
     # Xcodes writes UTF-16LE with BOM.
     contents = open(strings, 'rb').read()
     if not contents.startswith('\xff\xfe' + '/* Localized'.encode('utf-16le')):
@@ skipping 14 matching lines @@
      set(['Contents/MacOS/Test App Gyp',
           'Contents/Info.plist',
           'Contents/Resources/English.lproj/MainMenu.nib',
           'Contents/PkgInfo',
           ] +
          [os.path.join('Contents/Resources/English.lproj', f)
              for f in strings_files]):
     test.fail_test()
 
   test.pass_test()