Add assertion to UniqueValueId constructor.

Add assertion to UniqueValueId constructor.

R=verwaest@chromium.org
BUG=

Committed: https://code.google.com/p/v8/source/detail?r=16652

[Yang, 2013-09-11 11:29:23]

Please take a look.

[Toon Verwaest, 2013-09-11 11:43:57]

https://codereview.chromium.org/23781006/diff/1/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):

https://codereview.chromium.org/23781006/diff/1/src/hydrogen-instructions.h#n...
src/hydrogen-instructions.h:315:
HeapObject::cast(*handle)->GetHeap()->IsInRootsArray(
IsInRootsArray is wrong, given that the values in there can still move. Don't
whitelist specific values in this constructor; but rather have special
constructors for those whitelisted values.

[Toon Verwaest, 2013-09-11 12:51:24]

lgtm with comment

https://codereview.chromium.org/23781006/diff/6001/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):

https://codereview.chromium.org/23781006/diff/6001/src/hydrogen-instructions....
src/hydrogen-instructions.h:312: explicit UniqueValueId(Handle<Object> handle) {
Euh, shouldn't remove the useful new assert though :)

[Yang, 2013-09-11 12:54:44]

https://codereview.chromium.org/23781006/diff/6001/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):

https://codereview.chromium.org/23781006/diff/6001/src/hydrogen-instructions....
src/hydrogen-instructions.h:312: explicit UniqueValueId(Handle<Object> handle) {
On 2013/09/11 12:51:25, Toon Verwaest wrote:
> Euh, shouldn't remove the useful new assert though :)

Right. Forgot to add that assert in the second attempt :). 

Added now.

[Yang, 2013-09-11 13:00:49]

Committed patchset #3 manually as r16652 (presubmit successful).