Add assertion to UniqueValueId constructor.

src/hydrogen-instructions.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 291 matching lines @@
   int32_t upper_;
   Range* next_;
   bool can_be_minus_zero_;
 };
 
 
 class UniqueValueId V8_FINAL {
  public:
   UniqueValueId() : raw_address_(NULL) { }
 
-  explicit UniqueValueId(Object* object) {
-    raw_address_ = reinterpret_cast<Address>(object);
-    ASSERT(IsInitialized());
-  }
-
   explicit UniqueValueId(Handle<Object> handle) {
+    ASSERT(!AllowHeapAllocation::IsAllowed() ||
+           handle->IsSmi() ||
+           HeapObject::cast(*handle)->GetHeap()->IsInRootsArray(

[Toon Verwaest, 2013/09/11 11:43:57]

IsInRootsArray is wrong, given that the values in there can still move. Don't
whitelist specific values in this constructor; but rather have special
constructors for those whitelisted values.

+               handle.location()));
     static const Address kEmptyHandleSentinel = reinterpret_cast<Address>(1);
     if (handle.is_null()) {
       raw_address_ = kEmptyHandleSentinel;
     } else {
       raw_address_ = reinterpret_cast<Address>(*handle);
       ASSERT_NE(kEmptyHandleSentinel, raw_address_);
     }
     ASSERT(IsInitialized());
   }
 
@@ skipping 2991 matching lines @@
       if (IsSpecialDouble()) {
         return true;
       }
       return false;
     }
     if (has_external_reference_value_) {
       return false;
     }
 
     ASSERT(!handle_.is_null());
-    Heap* heap = isolate()->heap();
-    ASSERT(unique_id_ != UniqueValueId(heap->minus_zero_value()));
-    ASSERT(unique_id_ != UniqueValueId(heap->nan_value()));
-    return unique_id_ == UniqueValueId(heap->undefined_value()) ||
-           unique_id_ == UniqueValueId(heap->null_value()) ||
-           unique_id_ == UniqueValueId(heap->true_value()) ||
-           unique_id_ == UniqueValueId(heap->false_value()) ||
-           unique_id_ == UniqueValueId(heap->the_hole_value()) ||
-           unique_id_ == UniqueValueId(heap->empty_string());
+    Factory* factory = isolate()->factory();
+    ASSERT(unique_id_ != UniqueValueId(factory->minus_zero_value()));
+    ASSERT(unique_id_ != UniqueValueId(factory->nan_value()));
+    return unique_id_ == UniqueValueId(factory->undefined_value()) ||
+           unique_id_ == UniqueValueId(factory->null_value()) ||
+           unique_id_ == UniqueValueId(factory->true_value()) ||
+           unique_id_ == UniqueValueId(factory->false_value()) ||
+           unique_id_ == UniqueValueId(factory->the_hole_value()) ||
+           unique_id_ == UniqueValueId(factory->empty_string());
   }
 
   bool IsCell() const {
     return is_cell_;
   }
 
   virtual Representation RequiredInputRepresentation(int index) V8_OVERRIDE {
     return Representation::None();
   }
 
@@ skipping 3605 matching lines @@
   virtual bool IsDeletable() const V8_OVERRIDE { return true; }
 };
 
 
 #undef DECLARE_INSTRUCTION
 #undef DECLARE_CONCRETE_INSTRUCTION
 
 } }  // namespace v8::internal
 
 #endif  // V8_HYDROGEN_INSTRUCTIONS_H_