Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2378033002: Decouple WakeLock from direct //content dependencies (Closed)

Created:
4 years, 2 months ago by blundell
Modified:
4 years, 2 months ago
Reviewers:
jam, alogvinov
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Decouple WakeLock from direct //content dependencies As part of the Content Modularization Project, this CL removes direct knowledge of //content from //content/browser's wake lock service. The design follows that described here: https://docs.google.com/document/d/1683obWqUStROtJHgkveAWbnGi-W3P7gMylzYeImEzBU/edit#heading=h.jr0fqceqrud1 Note that this CL does not remove synchronous dependencies of this code on //content: on Android a callback is passed in in order to obtain the current NativeView when creating a wake lock. I do not know how to remove that dependency at this time: WebContent::GetNativeView() can return different values throughout the lifetime of a WebContents instance, at least on Android. Two unittests were removed from wake_lock_service_context.cc as they are not relevant at the //device level. The functionality of render frame deletion is still tested via the browsertest. BUG=612346 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/ebd751770f62eb05586897f4d2843f2c0d8af0b9 Cr-Commit-Position: refs/heads/master@{#422397}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -137 lines) Patch
M content/browser/frame_host/render_frame_host_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/wake_lock/wake_lock_service_context.h View 3 chunks +18 lines, -25 lines 0 comments Download
M content/browser/wake_lock/wake_lock_service_context.cc View 3 chunks +22 lines, -37 lines 0 comments Download
M content/browser/wake_lock/wake_lock_service_context_unittest.cc View 2 chunks +22 lines, -56 lines 0 comments Download
M content/browser/wake_lock/wake_lock_service_impl.h View 2 chunks +2 lines, -5 lines 0 comments Download
M content/browser/wake_lock/wake_lock_service_impl.cc View 1 chunk +15 lines, -11 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
blundell
4 years, 2 months ago (2016-09-28 14:18:42 UTC) #7
jam
lgtm
4 years, 2 months ago (2016-09-29 20:08:50 UTC) #8
alogvinov
lgtm lgtm
4 years, 2 months ago (2016-09-30 09:15:30 UTC) #9
alogvinov
lgtm
4 years, 2 months ago (2016-09-30 09:15:34 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2378033002/1
4 years, 2 months ago (2016-10-03 09:30:12 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-03 10:42:07 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 10:44:21 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ebd751770f62eb05586897f4d2843f2c0d8af0b9
Cr-Commit-Position: refs/heads/master@{#422397}

Powered by Google App Engine
This is Rietveld 408576698