Chromium Code Reviews
DescriptionDecouple WakeLock from direct //content dependencies
As part of the Content Modularization Project, this CL removes direct
knowledge of //content from //content/browser's wake lock service.
The design follows that described here:
https://docs.google.com/document/d/1683obWqUStROtJHgkveAWbnGi-W3P7gMylzYeImEzBU/edit#heading=h.jr0fqceqrud1
Note that this CL does not remove synchronous dependencies of this code
on //content: on Android a callback is passed in in order to obtain
the current NativeView when creating a wake lock. I do not know how to
remove that dependency at this time: WebContent::GetNativeView() can
return different values throughout the lifetime of a WebContents instance,
at least on Android.
Two unittests were removed from wake_lock_service_context.cc as they are not
relevant at the //device level. The functionality of render frame deletion is
still tested via the browsertest.
BUG=612346
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
Committed: https://crrev.com/ebd751770f62eb05586897f4d2843f2c0d8af0b9
Cr-Commit-Position: refs/heads/master@{#422397}
Patch Set 1 #
Messages
Total messages: 15 (8 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||