Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: content/browser/wake_lock/wake_lock_service_impl.cc

Issue 2378033002: Decouple WakeLock from direct //content dependencies (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/wake_lock/wake_lock_service_impl.cc
diff --git a/content/browser/wake_lock/wake_lock_service_impl.cc b/content/browser/wake_lock/wake_lock_service_impl.cc
index c710f9badab76da4dda9bdc4681e3341d21ed4dc..6e0d159f631129bcfac9eb61e55cff994585b5ce 100644
--- a/content/browser/wake_lock/wake_lock_service_impl.cc
+++ b/content/browser/wake_lock/wake_lock_service_impl.cc
@@ -11,23 +11,27 @@
namespace content {
WakeLockServiceImpl::WakeLockServiceImpl(
- base::WeakPtr<WakeLockServiceContext> context,
- int render_process_id,
- int render_frame_id)
- : context_(context),
- render_process_id_(render_process_id),
- render_frame_id_(render_frame_id) {}
+ base::WeakPtr<WakeLockServiceContext> context)
+ : context_(context), wake_lock_request_outstanding_(false) {}
-WakeLockServiceImpl::~WakeLockServiceImpl() {}
+WakeLockServiceImpl::~WakeLockServiceImpl() {
+ CancelWakeLock();
+}
void WakeLockServiceImpl::RequestWakeLock() {
- if (context_)
- context_->RequestWakeLock(render_process_id_, render_frame_id_);
+ if (!context_ || wake_lock_request_outstanding_)
+ return;
+
+ wake_lock_request_outstanding_ = true;
+ context_->RequestWakeLock();
}
void WakeLockServiceImpl::CancelWakeLock() {
- if (context_)
- context_->CancelWakeLock(render_process_id_, render_frame_id_);
+ if (!context_ || !wake_lock_request_outstanding_)
+ return;
+
+ wake_lock_request_outstanding_ = false;
+ context_->CancelWakeLock();
}
} // namespace content
« no previous file with comments | « content/browser/wake_lock/wake_lock_service_impl.h ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698