Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2378013002: Site Settings Desktop: Make sure AllSites list doesn't show icon/menu per site. (Closed)

Created:
4 years, 2 months ago by Finnur
Modified:
4 years, 2 months ago
Reviewers:
dschuyler
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Site Settings Desktop: Make sure AllSites list doesn't show icon/menu per site. This CL also unifies the way we check for the ALL_SITES category. BUG=650560 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/c4bb8db63ac1856a29786bb0317f0fce06084134 Cr-Commit-Position: refs/heads/master@{#421789}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M chrome/browser/resources/settings/site_settings/site_list.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/site_settings/site_list.js View 3 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Finnur
4 years, 2 months ago (2016-09-28 20:04:18 UTC) #7
dschuyler
lgtm
4 years, 2 months ago (2016-09-28 21:20:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2378013002/1
4 years, 2 months ago (2016-09-29 09:36:00 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-29 09:41:29 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 09:45:21 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c4bb8db63ac1856a29786bb0317f0fce06084134
Cr-Commit-Position: refs/heads/master@{#421789}

Powered by Google App Engine
This is Rietveld 408576698