Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Unified Diff: chrome/browser/resources/settings/site_settings/site_list.js

Issue 2378013002: Site Settings Desktop: Make sure AllSites list doesn't show icon/menu per site. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/settings/site_settings/site_list.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/site_settings/site_list.js
diff --git a/chrome/browser/resources/settings/site_settings/site_list.js b/chrome/browser/resources/settings/site_settings/site_list.js
index b38743ed783e1b0fe4ed595b6f3e57ae6ebc339a..4c4b38f988953a0b5df9755d76e4e97f21820e95 100644
--- a/chrome/browser/resources/settings/site_settings/site_list.js
+++ b/chrome/browser/resources/settings/site_settings/site_list.js
@@ -130,7 +130,7 @@ Polymer({
* @private
*/
siteWithinCategoryChanged_: function(category, site) {
- if (category == this.category || this.category == settings.ALL_SITES)
+ if (category == this.category || this.allSites)
this.configureWidget_();
},
@@ -205,6 +205,8 @@ Polymer({
* @return {string} The icon to show (or blank, if none).
*/
computeIconControlledBy_: function(item) {
+ if (this.allSites)
+ return '';
return iconControlledBy[item.source] || '';
},
@@ -320,7 +322,7 @@ Polymer({
*/
appendSiteList_: function(sites, exceptionList) {
for (var i = 0; i < exceptionList.length; ++i) {
- if (this.category != settings.ALL_SITES) {
+ if (!this.allSites) {
if (exceptionList[i].setting == settings.PermissionValues.DEFAULT)
continue;
« no previous file with comments | « chrome/browser/resources/settings/site_settings/site_list.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698