Test coverage for bug in WmWindowAura::OnWindowVisibilityChanged()

ash/common/test/ash_test.h

Index: ash/common/test/ash_test.h
diff --git a/ash/common/test/ash_test.h b/ash/common/test/ash_test.h
index 4e55c7b923531e1761b914f52f8f86b85c265113..85d03938081be12380af19ad9af5840a53b75f6d 100644
--- a/ash/common/test/ash_test.h
+++ b/ash/common/test/ash_test.h
@@ -66,6 +66,13 @@ class AshTest : public testing::Test {
       ui::wm::WindowType type = ui::wm::WINDOW_TYPE_NORMAL,
       int shell_window_id = kShellWindowId_Invalid);
 
+  // Creates a visible window parented to |parent| with the specified bounds and

[James Cook, 2016/09/28 01:19:58]

nit: document that it creates and shows. (I've been burned many times in my own
code by forgetting to show windows. :-)

[sky, 2016/09/28 18:16:36]

Doesn't the visible imply shows?

[James Cook, 2016/09/28 19:02:49]

I guess, but I missed that. Up to you.

+  // id.
+  std::unique_ptr<WindowOwner> CreateChildWindow(
+      WmWindow* parent,
+      const gfx::Rect& bounds = gfx::Rect(),
+      int shell_window_id = kShellWindowId_Invalid);
+
   // Returns the Display for the secondary display. It's assumed there is two
   // displays.
   display::Display GetSecondaryDisplay();