Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1069)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/FakeSuggestionsSource.java

Issue 2377663002: [NTP Snippets] Introduce ContentSuggestion::ID (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/FakeSuggestionsSource.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/FakeSuggestionsSource.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/FakeSuggestionsSource.java
index bec2652b065b0993dea893b73096500dc69b9e03..325e618c615b1c71ed7214f1f0646a057fd7e119 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/FakeSuggestionsSource.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/FakeSuggestionsSource.java
@@ -70,14 +70,14 @@ public class FakeSuggestionsSource implements SuggestionsSource {
* Removes the given suggestion from the source and notifies any observer that it has been
* invalidated.
*/
- public void fireSuggestionInvalidated(@CategoryInt int category, String suggestionId) {
+ public void fireSuggestionInvalidated(@CategoryInt int category, String idWithinCategory) {
for (SnippetArticle suggestion : mSuggestions.get(category)) {
- if (suggestion.mId.equals(suggestionId)) {
+ if (suggestion.mIdWithinCategory.equals(idWithinCategory)) {
mSuggestions.get(category).remove(suggestion);
break;
}
}
- mObserver.onSuggestionInvalidated(category, suggestionId);
+ mObserver.onSuggestionInvalidated(category, idWithinCategory);
}
/**
@@ -102,8 +102,8 @@ public class FakeSuggestionsSource implements SuggestionsSource {
@Override
public void fetchSuggestionImage(SnippetArticle suggestion, Callback<Bitmap> callback) {
- if (mThumbnails.containsKey(suggestion.mId)) {
- callback.onResult(mThumbnails.get(suggestion.mId));
+ if (mThumbnails.containsKey(suggestion.mIdWithinCategory)) {
+ callback.onResult(mThumbnails.get(suggestion.mIdWithinCategory));
}
}

Powered by Google App Engine
This is Rietveld 408576698