chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java - Issue 2377663002: [NTP Snippets] Introduce ContentSuggestion::ID

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java

Issue 2377663002: [NTP Snippets] Introduce ContentSuggestion::ID (Closed)

Patch Set: rebase Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/FakeSuggestionsSource.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java

index 63482506e42039b7365ad72cc92c74231d399186..2b29f57d92dc5b291808a86bbb12c06c4f2c3b4e 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java

@@ -67,9 +67,9 @@ public class SuggestionsSection implements ItemGroup {

if (mMoreButton != null) mMoreButton.setDismissable(!hasSuggestions());

}

- public void removeSuggestionById(String suggestionId) {

+ public void removeSuggestionById(String idWithinCategory) {

for (SnippetArticle suggestion : mSuggestions) {

- if (suggestion.mId.equals(suggestionId)) {

+ if (suggestion.mIdWithinCategory.equals(idWithinCategory)) {

removeSuggestion(suggestion);

return;

}