Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1333)

Issue 2377453003: Move extensions_strings.grd to extensions/strings/ (Closed)

Created:
4 years, 2 months ago by brettw
Modified:
4 years, 2 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move extensions_strings.grd to extensions/strings/ This was in the extensions root directory but the rest of the strings resources and the build rule are in the strings subdirectory. This moves the .grd file with everything else. Committed: https://crrev.com/0f3842e837a2d09f42da292772462e7fca2e8c0d Cr-Commit-Position: refs/heads/master@{#421328}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -402 lines) Patch
D extensions/extensions_strings.grd View 1 chunk +0 lines, -344 lines 0 comments Download
M extensions/strings/BUILD.gn View 1 chunk +1 line, -4 lines 0 comments Download
A + extensions/strings/extensions_strings.grd View 1 chunk +52 lines, -52 lines 0 comments Download
M tools/gritsettings/resource_ids View 1 chunk +1 line, -1 line 0 comments Download
M tools/gritsettings/translation_expectations.pyl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
brettw
4 years, 2 months ago (2016-09-27 19:57:52 UTC) #2
Ken Rockot(use gerrit already)
LGTM
4 years, 2 months ago (2016-09-27 19:59:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2377453003/1
4 years, 2 months ago (2016-09-27 20:08:21 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-27 20:52:59 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 20:56:39 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0f3842e837a2d09f42da292772462e7fca2e8c0d
Cr-Commit-Position: refs/heads/master@{#421328}

Powered by Google App Engine
This is Rietveld 408576698