Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: extensions/strings/BUILD.gn

Issue 2377453003: Move extensions_strings.grd to extensions/strings/ (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/extensions_strings.grd ('k') | extensions/strings/extensions_strings.grd » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/strings/BUILD.gn
diff --git a/extensions/strings/BUILD.gn b/extensions/strings/BUILD.gn
index bd9833b3070100f1f0c5221b12aff8831b8b1805..56145e79dac425d5ac367624ae3c0fa9ada68782 100644
--- a/extensions/strings/BUILD.gn
+++ b/extensions/strings/BUILD.gn
@@ -8,10 +8,7 @@ assert(enable_extensions)
# GYP version: extensions/extensions_strings.gyp:extensions_strings
grit("strings") {
- # This target is in this directory since it matches the output grit path for
- # the GYP version of this target. Weirdly, it does not match the input path.
- # The .grd should probably be moved here.
- source = "../extensions_strings.grd"
+ source = "extensions_strings.grd"
outputs = [
"grit/extensions_strings.h",
"extensions_strings_am.pak",
« no previous file with comments | « extensions/extensions_strings.grd ('k') | extensions/strings/extensions_strings.grd » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698