Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Unified Diff: Source/core/html/canvas/CanvasStyle.cpp

Issue 237743009: Don't parse colors for <canvas> in quirks mode (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/canvas/canvas-fillStyle-no-quirks-parsing.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/canvas/CanvasStyle.cpp
diff --git a/Source/core/html/canvas/CanvasStyle.cpp b/Source/core/html/canvas/CanvasStyle.cpp
index 28877cd99ef4debd23e9d4d7ee2e606db7cac509..d02914b3b0847a667bf3f88f86e55b35170fd626 100644
--- a/Source/core/html/canvas/CanvasStyle.cpp
+++ b/Source/core/html/canvas/CanvasStyle.cpp
@@ -46,7 +46,7 @@ static ColorParseResult parseColor(RGBA32& parsedColor, const String& colorStrin
{
if (equalIgnoringCase(colorString, "currentcolor"))
return ParsedCurrentColor;
- if (BisonCSSParser::parseColor(parsedColor, colorString))
+ if (BisonCSSParser::parseColor(parsedColor, colorString, true /* strict */))
Justin Novosad 2014/04/16 16:26:49 The Blinky way of documenting the meaning of 'true
fs 2014/04/16 16:34:10 Ah, yes... I keep forgetting that rule (which thin
return ParsedRGBA;
if (BisonCSSParser::parseSystemColor(parsedColor, colorString))
return ParsedSystemColor;
« no previous file with comments | « LayoutTests/fast/canvas/canvas-fillStyle-no-quirks-parsing.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698